Skip to content

Commit 155d103

Browse files
authored
YPE-1000: feat(verse-of-the-day): update default bible version to niv
feat(verse-of-the-day): update default bible version to niv The default Bible version for the VerseOfTheDay component has been updated from KJV (version ID 1) to NIV (version ID 111). This change reflects the new required default version for the application. Mock data and handlers have been updated to reflect the new default version.
1 parent c0eefdf commit 155d103

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

packages/ui/src/components/verse-of-the-day.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ export const Default: Story = {
7979
const callArgs = mockSpy.mock.calls[0]?.[0];
8080
await expect(callArgs).toHaveProperty('text');
8181
await expect(callArgs?.text).toContain('For I am about to do something new');
82-
await expect(callArgs?.text).toContain('Isaiah 43:19 KJV');
82+
await expect(callArgs?.text).toContain('Isaiah 43:19 NIV');
8383
},
8484
};
8585

packages/ui/src/components/verse-of-the-day.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export type VerseOfTheDayProps = {
1919
*/
2020
background?: 'light' | 'dark';
2121
/**
22-
* The Bible Translation version id to use, defaults to 1 (KJV).
22+
* The Bible Translation version id to use, defaults to 111 (NIV).
2323
*/
2424
versionId?: number;
2525
/**
@@ -69,7 +69,7 @@ async function share({ title, text, url }: { title?: string; text: string; url?:
6969
* @example
7070
* ```tsx
7171
* <VerseOfTheDay
72-
* versionId={1}
72+
* versionId={111}
7373
* showSunIcon={true}
7474
* showShareButton={false}
7575
* showBibleAppAttribution={true}
@@ -80,7 +80,7 @@ async function share({ title, text, url }: { title?: string; text: string; url?:
8080
export function VerseOfTheDay({
8181
background,
8282
dayOfYear,
83-
versionId = 1, // KJV by default
83+
versionId = 111, // NIV by default
8484
showSunIcon = true,
8585
showShareButton = true,
8686
showBibleAppAttribution = true,

packages/ui/src/test/mock-data/passages.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@
5656
"ISA.43.19": {
5757
"id": "ISA.43.19",
5858
"content": "<div><div class=\"q1\"><span class=\"yv-v\" v=\"19\"></span><span class=\"yv-vlbl\">19</span>For I am about to do something new.</div><div class=\"q2\">See, I have already begun! Do you not see it?</div><div class=\"q1\">I will make a pathway through the wilderness.</div><div class=\"q2\">I will create rivers in the dry wasteland.</div></div>",
59-
"version_id": 1,
59+
"version_id": 111,
6060
"reference": "Isaiah 43:19"
6161
},
6262
"JHN.1.51": {

packages/ui/src/test/mocks/handlers.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export const globalHandlers = [
4747
}),
4848

4949
// Isaiah passage for verse of the day
50-
http.get('*/v1/bibles/1/passages/ISA.43.19', () => {
50+
http.get('*/v1/bibles/111/passages/ISA.43.19', () => {
5151
return HttpResponse.json(mockPassages['ISA.43.19']);
5252
}),
5353

@@ -56,10 +56,6 @@ export const globalHandlers = [
5656
return HttpResponse.json(mockBibles.individual['111']);
5757
}),
5858

59-
http.get('*/v1/bibles/1', () => {
60-
return HttpResponse.json(mockBibles.individual['1']);
61-
}),
62-
6359
http.get('*/v1/bibles/1588', () => {
6460
return HttpResponse.json(mockBibles.individual['1588']);
6561
}),

0 commit comments

Comments
 (0)