Skip to content

Commit 62ee22a

Browse files
authored
fix: use BSB (3034) consistently as the default/preview Bible version
1 parent e4a3f2e commit 62ee22a

File tree

9 files changed

+22
-26
lines changed

9 files changed

+22
-26
lines changed

Examples/SampleApp/WidgetView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ struct WidgetView: View {
55
var body: some View {
66
BibleWidgetView(
77
reference: BibleReference(
8-
versionId: 111, bookUSFM: "2CO", chapter: 1, verseStart: 3, verseEnd: 4
8+
versionId: 3034, bookUSFM: "2CO", chapter: 1, verseStart: 3, verseEnd: 4
99
),
1010
fontSize: 18
1111
)

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ import YouVersionPlatform
9999
struct DemoView: View {
100100
var body: some View {
101101
BibleTextView(
102-
BibleReference(versionId: 111, bookUSFM: "JHN", chapter: 3, verse: 16)
102+
BibleReference(versionId: 3034, bookUSFM: "JHN", chapter: 3, verse: 16)
103103
)
104104
}
105105
}
@@ -112,7 +112,7 @@ import YouVersionPlatform
112112
struct DemoView: View {
113113
var body: some View {
114114
BibleTextView(
115-
BibleReference(versionId: 111, bookUSFM: "JHN", chapter: 3, verseStart: 16, verseEnd: 20)
115+
BibleReference(versionId: 3034, bookUSFM: "JHN", chapter: 3, verseStart: 16, verseEnd: 20)
116116
)
117117
}
118118
}
@@ -125,7 +125,7 @@ import YouVersionPlatform
125125
struct DemoView: View {
126126
var body: some View {
127127
BibleTextView(
128-
BibleReference(versionId: 111, bookUSFM: "JHN", chapter: 3)
128+
BibleReference(versionId: 3034, bookUSFM: "JHN", chapter: 3)
129129
)
130130
}
131131
}

Sources/YouVersionPlatformCore/Bible/BibleVersion.swift

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -114,22 +114,18 @@ public struct BibleVersion: Codable, Sendable, Hashable, Equatable {
114114

115115
public static var preview: BibleVersion {
116116
// Create a minimal BibleVersion for preview purposes
117-
let promotionalContent = """
118-
King James Version (KJV)
119-
120-
The King James Version (KJV) of the holy Bible was first printed in 1611, but the main edition used today is the 1769 version. The King James Version (KJV) is also known as the Authorized (or Authorised) Version (AV) because it was authorized to be read in churches. For over 300 years it was the main English translation used in the English speaking world, and is much admired and respected. About 400 words and phrases coined or popularised by the King James Version are part the English language today.
121-
"""
117+
let promotionalContent = "This is minimal preview data for the Berean Standard Bible"
122118
return BibleVersion(
123-
id: 1,
124-
abbreviation: "KJV",
119+
id: 3034,
120+
abbreviation: "BSB",
125121
promotionalContent: promotionalContent,
126122
copyright: nil,
127123
languageTag: "en",
128-
localizedAbbreviation: "KJV",
129-
localizedTitle: "King James Version",
130-
readerFooter: "Text is from the King James Version",
131-
readerFooterUrl: "https://www.biblesociety.org.uk",
132-
title: "King James Version",
124+
localizedAbbreviation: "BSB",
125+
localizedTitle: "Berean Standard Bible",
126+
readerFooter: "Text is from the Berean Standard Bible",
127+
readerFooterUrl: "https://berean.bible",
128+
title: "Berean Standard Bible",
133129
organizationId: "1234-abcd-4321-fedc-0123456789ab",
134130
bookCodes: nil,
135131
books: nil,

Sources/YouVersionPlatformReader/BibleReaderView.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ public struct BibleReaderView: View {
282282

283283
#Preview {
284284
BibleReaderView(
285-
reference: BibleReference(versionId: 206, bookUSFM: "PSA", chapter: 117),
285+
reference: BibleReference(versionId: 3034, bookUSFM: "PSA", chapter: 117),
286286
appName: "BibleReaderViewPreview",
287287
signInMessage: "This paragraph needs to explain why the user should sign in."
288288
)

Sources/YouVersionPlatformReader/ViewModels/BibleReaderViewModel+Preview.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@ extension BibleReaderViewModel {
77

88
public static var preview: BibleReaderViewModel {
99
// Create a minimal BibleReaderViewModel for preview purposes
10-
let vm = BibleReaderViewModel(reference: BibleReference(versionId: 1, bookUSFM: "GEN", chapter: 1))
10+
let vm = BibleReaderViewModel(reference: BibleReference(versionId: 3034, bookUSFM: "GEN", chapter: 1))
1111

1212
let previewVersion = BibleVersion.preview
1313
vm.version = previewVersion
1414
vm.myVersions = [previewVersion]
1515
vm.selectedVersion = previewVersion
1616

17-
let footnoteReference = BibleReference(versionId: 111, bookUSFM: "JHN", chapter: 21, verse: 1)
17+
let footnoteReference = BibleReference(versionId: 3034, bookUSFM: "JHN", chapter: 21, verse: 1)
1818
vm.footnotesToDisplay = [
1919
BibleFootnote(text: BibleAttributedString("Footnote text goes here."), reference: footnoteReference),
2020
BibleFootnote(text: BibleAttributedString("Second Footnote text goes here. This time the footnote is fairly long."), reference: footnoteReference)

Sources/YouVersionPlatformReader/ViewModels/BibleReaderViewModel.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ final class BibleReaderViewModel {
3434
} else {
3535
// no specified or saved version, so, pick a downloaded one, else a safe default.
3636
let downloads = VersionDownloadCache.downloadedVersions
37-
let versionId = reference?.versionId ?? downloads.first ?? savedIds.first ?? 206
37+
let versionId = reference?.versionId ?? downloads.first ?? savedIds.first ?? 3034
3838
self.reference = BibleReference(versionId: versionId, bookUSFM: "JHN", chapter: 1)
3939
}
4040
}

Sources/YouVersionPlatformUI/Objects/BibleVersion+Additions.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ public extension BibleVersion {
88
}
99
return book.title ?? book.fullTitle
1010
}
11-
// Example: "https://www.bible.com/bible/111/1SA.3.10.NIV"
11+
// Example: "https://www.bible.com/bible/3034/1SA.3.10.BSB"
1212
func shareUrl(reference: BibleReference) -> URL? {
1313
let prefix = "https://www.bible.com/bible/\(id)/"
1414
let book = reference.bookUSFM

Sources/YouVersionPlatformUI/Views/VotdView.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public struct VotdView: View {
99

1010
@State private var bibleVersionId: Int
1111

12-
public init(bibleVersionId: Int = 111) {
12+
public init(bibleVersionId: Int = 3034) {
1313
self.bibleVersionId = bibleVersionId
1414
}
1515

@@ -102,5 +102,5 @@ public struct VotdView: View {
102102
}
103103

104104
#Preview {
105-
VotdView(bibleVersionId: 206)
105+
VotdView(bibleVersionId: 3034)
106106
}

Tests/YouVersionPlatformCoreTests/LanguagesAPITests.swift

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import Testing
2424
variants: ["US", "GB"],
2525
countries: ["US", "GB", "CA"],
2626
textDirection: "ltr",
27-
defaultBibleId: 111
27+
defaultBibleId: 3034
2828
),
2929
LanguageOverview(
3030
id: "es",
@@ -55,7 +55,7 @@ import Testing
5555
#expect(languages.count == 2)
5656
#expect(languages[0].id == "en")
5757
#expect(languages[0].language == "English")
58-
#expect(languages[0].defaultBibleId == 111)
58+
#expect(languages[0].defaultBibleId == 3034)
5959
#expect(languages[1].id == "es")
6060
#expect(languages[1].language == "Spanish")
6161
#expect(languages[1].defaultBibleId == 128)
@@ -80,7 +80,7 @@ import Testing
8080
variants: ["US"],
8181
countries: ["US"],
8282
textDirection: "ltr",
83-
defaultBibleId: 111
83+
defaultBibleId: 3034
8484
)
8585
]
8686

0 commit comments

Comments
 (0)