Skip to content

Commit 41e01ff

Browse files
authored
Add PR reference to TODO comment about LabelNames replacement (#15)
* 💡(metadata_query): Add PR reference to TODO comment about LabelNames replacement [Explanation: Added GitHub PR link (#1850) to existing TODO comment to provide context for future type replacement from []string to model.LabelNames] * 💡(labels.go): Improve TODO comment clarity and formatting ```diff -// TODO: replace []string with model.LabelNames ? prometheus/client_golang#1850 +// TODO: Replace []string with model.LabelNames (see prometheus/client_golang#1850). ```
1 parent 0d5192f commit 41e01ff

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pkg/metadata_query/labels.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ type LabelNamesArguments struct {
2828
}
2929

3030
type LabelNamesResult struct {
31-
// TODO: replace []string with model.LabelNames ?
31+
// TODO: Replace []string with model.LabelNames (see https://github.com/prometheus/client_golang/pull/1850).
3232
LabelNames []string `json:"names" jsonschema:"Names is a list of string label names."`
3333
Warnings v1.Warnings `json:"warnings,omitempty"`
3434
}

0 commit comments

Comments
 (0)