Skip to content

Commit a496ade

Browse files
committed
fixup! restore dependency metadata, move workaround to CI configuration and document it
1 parent 29d21e8 commit a496ade

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

.circleci/config.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,6 @@ commands:
5252
5353
# install yt_astro_analysis with extra dev dependencies
5454
python -m pip install .
55-
# tmp: build girder client from source with an older setuptools
56-
# this shouldn't be necessary, long term
57-
# see https://github.com/girder/girder/pull/3717
58-
python -m pip install "setuptools<81" setuptools-scm
59-
python -m pip install girder-client --no-build-isolation
6055
python -m pip install --requirement requirements/tests.txt
6156
6257
# configure yt

requirements/tests.txt

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,8 @@ scipy
55
# test dependencies
66
pytest
77
girder-client
8+
9+
# tmp: girder-client 3.2.8 has an undeclared runtime dependency on setuptools
10+
# but it's already patched upstream
11+
# https://github.com/girder/girder/pull/3696
12+
setuptools<81

0 commit comments

Comments
 (0)