Skip to content

Commit 8b96344

Browse files
committed
代码生成器:code review
1 parent 97cf3aa commit 8b96344

File tree

5 files changed

+10
-3
lines changed

5 files changed

+10
-3
lines changed

src/views/infra/demo/demo01/Demo01ContactForm.vue

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
<el-form-item label="简介">
1919
<Editor v-model="formData.description" :min-height="192"/>
2020
</el-form-item>
21+
<!-- TODO @puhui999:头像应该是 imageupload 组件 -->
2122
<el-form-item label="头像" prop="avatar">
2223
<el-input v-model="formData.avatar" placeholder="请输入头像" />
2324
</el-form-item>
@@ -90,9 +91,9 @@ export default {
9091
this.formLoading = true;
9192
try {
9293
const that = this;
93-
let data = this.formData;
94+
let data = this.formData; // TODO @puhui999:const data
9495
95-
this.getRef("formRef").validate(valid => {
96+
this.getRef("formRef").validate(valid => { // TODO @puhui999:上面不用空行;
9697
if (!valid) {
9798
return;
9899
}
@@ -116,6 +117,7 @@ export default {
116117
this.formLoading = false
117118
}
118119
},
120+
// TODO @puhui999:这个在研究下,看看有没办法回到 $refs
119121
getRef(refName){ // TODO puhui999: 获得表单 ref,提取出来的目的呢是解决 $ 在 if 中 end闭合不了的问题,代码生成后可删除此方法
120122
return this.$refs[refName]
121123
},

src/views/infra/demo/demo03/erp/index.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@
8686
@pagination="getList"/>
8787
<!-- 对话框(添加 / 修改) -->
8888
<Demo03StudentForm ref="formRef" @success="getList"/>
89-
<!-- 子表的列表 -->
89+
<!-- 子表的列表 --> <!-- TODO @puhui999:Demo03CourseList 和 Demo03GradeList 是不是不要有边距,应该和上面列表一样,是顶格的 -->
9090
<el-tabs v-model="subTabsName">
9191
<el-tab-pane label="学生课程" name="demo03Course">
9292
<Demo03CourseList v-if="currentRow.id" :student-id="currentRow.id"/>

src/views/infra/demo/demo03/inner/index.vue

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
</el-row>
4040

4141
<el-table v-loading="loading" :data="list" :stripe="true" :show-overflow-tooltip="true">
42+
<!-- TODO @puhui999:居中没生效 -->
4243
<!-- 子表的列表 -->
4344
<el-table-column type="expand">
4445
<template #default="scope">
@@ -157,6 +158,7 @@ export default {
157158
},
158159
/** 添加/修改操作 */
159160
openForm(id) {
161+
// TODO @puhui999:$refs 在 vm 里面怎么写,可以看看这里噢。
160162
this.$refs["formRef"].open(id);
161163
},
162164
/** 删除按钮操作 */

src/views/infra/demo/demo03/normal/Demo03StudentForm.vue

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ export default {
103103
const that = this;
104104
let data = this.formData;
105105
let validate = false;
106+
// TODO @puhui999:要不要改成 await 风格;
106107
// 校验主表
107108
this.getRef("formRef").validate(valid => {
108109
validate = valid;

src/views/infra/demo/demo03/normal/components/Demo03CourseForm.vue

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
</el-table-column>
3232
</el-table>
3333
</el-form>
34+
<!-- TODO @puhui999:居中没生效 -->
3435
<el-row justify="center" class="mt-3">
3536
<el-button @click="handleAdd" round>+ 添加学生课程</el-button>
3637
</el-row>
@@ -72,6 +73,7 @@ export default {
7273
}
7374
try {
7475
this.formLoading = true;
76+
// TODO @puhui999:涉及到 that 的地方,看看怎么都改成 this
7577
const that = this;
7678
Demo03StudentApi.getDemo03CourseListByStudentId(val).then(res => {
7779
that.formData = res.data;

0 commit comments

Comments
 (0)