Skip to content

Commit 1e70a1d

Browse files
committed
📖 CRM:待办事项的 code review
1 parent 68fc176 commit 1e70a1d

File tree

4 files changed

+7
-2
lines changed

4 files changed

+7
-2
lines changed

src/api/crm/message/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ export interface CustomerVO {
3434
}
3535

3636
// 查询客户列表
37+
// TODO @芋艿:看看是不是后续融合到 getCustomerPage 里;
3738
export const getTodayCustomerPage = async (params) => {
3839
return await request.get({ url: `/crm/message/todayCustomer`, params })
3940
}

src/router/modules/remaining.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -537,6 +537,7 @@ const remainingRouter: AppRouteRecordRaw[] = [
537537
noCache: true,
538538
hidden: true
539539
},
540+
// TODO @db52:后面搞,搞成菜单
540541
component: () => import('@/views/crm/message/index.vue')
541542
}
542543
]

src/views/crm/message/index.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
</el-col>
2121
</el-row>
2222
</template>
23-
23+
<!-- @dbh52:模块改成 backlog 会更合适,待办事项 -->
2424
<script lang="ts" setup>
2525
import TodayCustomer from './tables/TodayCustomer.vue'
2626
import FollowLeads from './tables/FollowLeads.vue'

src/views/crm/message/tables/TodayCustomer.vue

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,11 +125,12 @@ import { DICT_TYPE } from '@/utils/dict'
125125
import { dateFormatter } from '@/utils/formatTime'
126126
import * as MessageApi from '@/api/crm/message'
127127
128-
const title = ref('今日需联系客户')
128+
const title = ref('今日需联系客户') // TODO @dbh52:这个不用枚举一个变量哈;
129129
const loading = ref(true) // 列表的加载中
130130
const total = ref(0) // 列表的总页数
131131
const list = ref([]) // 列表的数据
132132
const queryParams = ref<{
133+
// TODO @dbh52:这个 ref 类型定义可以去掉哈。之前定义的原因,是因为 idea 报错了;默认 idea 可以推导出类型
133134
pageNo: number
134135
pageSize: number
135136
contactStatus: number | undefined
@@ -149,6 +150,7 @@ const CONTACT_STATUS = [
149150
]
150151
151152
const SCENE_TYPES = [
153+
// TODO 芋艿:貌似可以搞成全局枚举
152154
{ label: '我负责的', value: 1 },
153155
{ label: '我跟进的', value: 2 },
154156
{ label: '我参与的', value: 3 },
@@ -182,6 +184,7 @@ const resetQuery = (func: Function | undefined = undefined) => {
182184
contactStatus: 1,
183185
sceneType: 1
184186
}
187+
// TODO @dbh52:这里的 func 是不是可以去掉哈;
185188
func && func()
186189
handleQuery()
187190
}

0 commit comments

Comments
 (0)