[FEAT] Make use of theme_type_variation variable

[Pheubel]

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
When creating an option menu with the plugin, i wanted to make use of a theme that i can reuse for the rest of my controls, so that i have to do less manual work dragging and dropping assets.

When i was trying to change the buttons for the spinbox, i followed the instructions in the wiki. But when i made the custom type as described in the how to create a theme section it did not seem to apply it as expected. I have my theme as a project default to automatically apply it to control nodes to reduce work. Instead of arrow icons, i did not get any visible arrows

Describe the solution you'd like
Instead of setting the theme for each component in a SB control node from the inspector, it would be a nicer solution to have the theme_type_variation be set for each of the components in the SB control nodes and to instead use the theme attached to the control node as the base used for the components. I tried it on my own in the SBSpinButton

func _setup_variables() -> void:
	_update_popup_items()
	prev_button.theme = nav_theme
	next_button.theme = nav_theme
	prev_button.flat = nav_button_flat
	next_button.flat = nav_button_flat
	next_button.theme_type_variation = &"SBNextNav"
	prev_button.theme_type_variation = &"SBPrevNav"
	content_container.add_theme_constant_override("separation", nav_separation)

This small addition made my arrows appear as expected, as i had the icons set in the SBNextNav and SBPrevNav types in the theme.

To me it makes sense that it should be used, as the components are fully named and documented in the Theme module section on the wiki and as mentioned earlier, in the how to create a theme section, it is explained how to you should go about naming the types.

Describe alternatives you've considered
N/A

Additional context
N/A

[yudinikita]

Thanks for the suggestion, I really like it. I'm still thinking about the theme, it would be better to add the theme_type_variation app.

Ideally, it would be placed in the themes module:

# core/theme_module/base_theme_module.gd
func _initialize_controls() -> void:
	_controls = {
		C_WRAPPER: _owner.wrapper,
		C_TITLE: _owner.title_label,
		C_DESCRIPTION: _owner.desc_label,
		C_VALUE: _owner.value_text_label,
		C_LEFT_ICON: _owner.left_icon_button,
		C_RIGHT_ICON: _owner.right_icon_button,
		C_NEXT_NAV: _owner.next_button,
		C_PREV_NAV: _owner.prev_button,
		C_SLIDER: _owner.slider,
		C_SLIDER_VALUE: _owner.slider_value,
		C_SLIDER_TOOLTIP: _owner.slider_value_tooltip,
		C_CONTENT: _owner.content_button
	}
	_owner.next_button.theme_type_variation = &"SBNextNav"
	_owner.prev_button.theme_type_variation = &"SBPrevNav"

I think this is a good place to insert this code. But I'm not sure about the side effects. Could you take them from yourself and check this? If everything is okay, then I can make changes and publish them for everyone.

[Pheubel]

Thanks for the suggestion, I really like it. I'm still thinking about the theme, it would be better to add the theme_type_variation app.

Ideally, it would be placed in the themes module:

core/theme_module/base_theme_module.gd

func _initialize_controls() -> void:
_controls = {
C_WRAPPER: _owner.wrapper,
C_TITLE: _owner.title_label,
C_DESCRIPTION: _owner.desc_label,
C_VALUE: _owner.value_text_label,
C_LEFT_ICON: _owner.left_icon_button,
C_RIGHT_ICON: _owner.right_icon_button,
C_NEXT_NAV: _owner.next_button,
C_PREV_NAV: _owner.prev_button,
C_SLIDER: _owner.slider,
C_SLIDER_VALUE: _owner.slider_value,
C_SLIDER_TOOLTIP: _owner.slider_value_tooltip,
C_CONTENT: _owner.content_button
}
_owner.next_button.theme_type_variation = &"SBNextNav"
_owner.prev_button.theme_type_variation = &"SBPrevNav"

I think this is a good place to insert this code. But I'm not sure about the side effects. Could you take them from yourself and check this? If everything is okay, then I can make changes and publish them for everyone.

I changed that bit of the code, but instead of just assigning the button theme types, i did it with all the controls, like this

func _initialize_controls() -> void:
	_controls = {
		C_WRAPPER: _owner.wrapper,
		C_TITLE: _owner.title_label,
		C_DESCRIPTION: _owner.desc_label,
		C_VALUE: _owner.value_text_label,
		C_LEFT_ICON: _owner.left_icon_button,
		C_RIGHT_ICON: _owner.right_icon_button,
		C_NEXT_NAV: _owner.next_button,
		C_PREV_NAV: _owner.prev_button,
		C_SLIDER: _owner.slider,
		C_SLIDER_VALUE: _owner.slider_value,
		C_SLIDER_TOOLTIP: _owner.slider_value_tooltip,
		C_CONTENT: _owner.content_button
	}

	for control_type in _controls:
		var control: Control = _controls[control_type] as Control
		control.theme_type_variation = control_type

To see if it had any visible changes on existing projects i just looked at the example and cross-referenced that. As far as i can tell i don't see any notable changes.

I didn't test out if icons work inside of the theme, since the project the plugin was made in is based on 4.2, but in 4.3 the Button class got an icon theming option. But with what i tried in my own project, i believe it should work as expected.

Applying the theme onto a spinbox directly seems to change almost everything as expected, the only exception is that without setting an icon for the buttons, the style would not show, as it assumes it is 0x0. But that is a different issue unrelated to this one.