Skip to content

Commit 92a7e35

Browse files
[Backport 2.6] Quote yugabyte gflag overrides
Summary: In order to maintain compatibility with previous chart behavior, it's necessary to quote gflag overrides in order to prevent breakages due to multi-word gflag values. This issue was introduced in 4e560f0 Test Plan: Run template containing multi-word gflag value without this change: $ helm install yugabyte ./ --set gflags.master.test1234="asdf asdf" --dry-run --debug ... --test1234=asdf asdf \ ... Run template contianing multi-word gflag value with this change: $ helm install yugabyte ./ --set gflags.master.test1234="asdf asdf" --dry-run --debug ... --test1234="asdf asdf" \ ... Verify that the argument value is properly quoted. Reviewers: sanketh Reviewed By: sanketh Subscribers: yugaware Differential Revision: https://phabricator.dev.yugabyte.com/D12064
1 parent bfadd37 commit 92a7e35

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

stable/yugabyte/templates/service.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ spec:
297297
--num_cpus={{ ceil $root.Values.resource.master.requests.cpu }} \
298298
--undefok=num_cpus,enable_ysql \
299299
{{- range $flag, $override := $root.Values.gflags.master }}
300-
--{{ $flag }}={{ $override }} \
300+
--{{ $flag }}={{ quote $override }} \
301301
{{- end }}
302302
{{- if $root.Values.tls.enabled }}
303303
--certs_dir=/opt/certs/yugabyte \
@@ -346,7 +346,7 @@ spec:
346346
--use_cassandra_authentication=true \
347347
{{- end }}
348348
{{- range $flag, $override := $root.Values.gflags.tserver }}
349-
--{{ $flag }}={{ $override }} \
349+
--{{ $flag }}={{ quote $override }} \
350350
{{- end }}
351351
{{- if $root.Values.tls.enabled }}
352352
--certs_dir=/opt/certs/yugabyte \

0 commit comments

Comments
 (0)