Commit 92a7e35
committed
[Backport 2.6] Quote yugabyte gflag overrides
Summary:
In order to maintain compatibility with previous chart behavior, it's
necessary to quote gflag overrides in order to prevent breakages due to
multi-word gflag values.
This issue was introduced in 4e560f0
Test Plan:
Run template containing multi-word gflag value without this change:
$ helm install yugabyte ./ --set gflags.master.test1234="asdf asdf" --dry-run --debug
...
--test1234=asdf asdf \
...
Run template contianing multi-word gflag value with this change:
$ helm install yugabyte ./ --set gflags.master.test1234="asdf asdf" --dry-run --debug
...
--test1234="asdf asdf" \
...
Verify that the argument value is properly quoted.
Reviewers: sanketh
Reviewed By: sanketh
Subscribers: yugaware
Differential Revision: https://phabricator.dev.yugabyte.com/D120641 parent bfadd37 commit 92a7e35
1 file changed
+2
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
297 | 297 | | |
298 | 298 | | |
299 | 299 | | |
300 | | - | |
| 300 | + | |
301 | 301 | | |
302 | 302 | | |
303 | 303 | | |
| |||
346 | 346 | | |
347 | 347 | | |
348 | 348 | | |
349 | | - | |
| 349 | + | |
350 | 350 | | |
351 | 351 | | |
352 | 352 | | |
| |||
0 commit comments