Skip to content

Commit a925eb5

Browse files
committed
Add more overrides
1 parent 4a57a02 commit a925eb5

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

stable/yugabyte/templates/master-gflags-secret.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ stringData:
4646
--num_cpus={{ ceil $root.Values.resource.master.requests.cpu }}
4747
--max_log_size=256
4848
--undefok=num_cpus,enable_ysql
49-
--rpc_bind_addresses={{ include "yugabyte.rpc_bind_address" $serviceValues }}
50-
--server_broadcast_addresses={{ include "yugabyte.server_broadcast_address" $serviceValues }}
49+
--rpc_bind_addresses={{ $root.Values.master.rpcBindAddress | default (include "yugabyte.rpc_bind_address" $serviceValues) }}
50+
--server_broadcast_addresses={{ $root.Values.master.serverBroadcastAddress | default (include "yugabyte.server_broadcast_address" $serviceValues) }}
5151
--webserver_interface={{ include "yugabyte.webserver_interface" $serviceValues }}
5252
{{- range $flag, $override := $root.Values.gflags.master }}
5353
--{{ $flag }}={{ $override }}

stable/yugabyte/templates/tserver-gflags-secret.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ stringData:
6262
--undefok=num_cpus,enable_ysql
6363
--use_node_hostname_for_local_tserver=true
6464
--cql_proxy_bind_address={{ include "yugabyte.cql_proxy_bind_address" $serviceValues }}
65-
--rpc_bind_addresses={{ include "yugabyte.rpc_bind_address" $serviceValues }}
65+
--rpc_bind_addresses={{ $root.Values.tserver.rpcBindAddress | default (include "yugabyte.rpc_bind_address" $serviceValues) }}
6666
--server_broadcast_addresses={{ $root.Values.tserver.serverBroadcastAddress | default (include "yugabyte.server_broadcast_address" $serviceValues) }}
6767
--webserver_interface={{ include "yugabyte.webserver_interface" $serviceValues }}
6868
{{- range $flag, $override := $root.Values.gflags.tserver }}

stable/yugabyte/values.yaml

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -457,6 +457,15 @@ master:
457457
# fieldPath: status.hostIP
458458
extraEnv: []
459459

460+
## Sets the --server_broadcast_addresses flag on the Master pods, no
461+
## preflight checks are done for this address. You might need to add
462+
## `use_private_ip: cloud` to the gflags.master and gflags.tserver.
463+
serverBroadcastAddress: ""
464+
465+
## Sets the --rpc_bind_addresses flag on the Master pods, no
466+
## preflight checks are done for this address.
467+
rpcBindAddress: ""
468+
460469
# secretEnv variables are used to expose secrets data as env variables in the master pod.
461470
# TODO Add namespace also to support copying secrets from other namespace.
462471
# secretEnv:
@@ -633,6 +642,10 @@ tserver:
633642
## `use_private_ip: cloud` to the gflags.master and gflags.tserver.
634643
serverBroadcastAddress: ""
635644

645+
## Sets the --rpc_bind_addresses flag on the TServer, no
646+
## preflight checks are done for this address.
647+
rpcBindAddress: ""
648+
636649
## Extra volumes
637650
## extraVolumesMounts are mandatory for each extraVolumes.
638651
## Ref: https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.22/#volume-v1-core
@@ -809,4 +822,4 @@ otelCollector:
809822
# for example: for IAM authentication in GKE.
810823
# nodeSelector:
811824
# iam.gke.io/gke-metadata-server-enabled: "true"
812-
825+

0 commit comments

Comments
 (0)