Skip to content

Commit 09b80ee

Browse files
committed
[#28705] docdb: Disable table level lock for ConcurrentDDLAnalyze test
Summary: Disable enable_object_locking_for_table_locks for 'ConcurrentDDLAnalyze' test. This test was designed to verify that a long-running ANALYZE operation can be interrupted by a concurrent DDL. However, with table-level locking enabled, this is no longer the case, ANALYZE acquires a table lock that blocks the other DDL from proceeding Jira: DB-18408 Test Plan: ./yb_build.sh --cxx-test pgwrapper_pg_auto_analyze-test --gtest_filter PgConcurrentDDLAnalyzeTest.ConcurrentDDLAnalyze Reviewers: myang, sanketh, rthallam Reviewed By: sanketh Subscribers: yguan, yql, ybase Differential Revision: https://phorge.dev.yugabyte.com/D47023
1 parent db528be commit 09b80ee

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/yb/yql/pgwrapper/pg_auto_analyze-test.cc

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1243,6 +1243,11 @@ class PgConcurrentDDLAnalyzeTest : public LibPqTestBase {
12431243
// we want to trigger ANALYZE explicitly similar to what auto analyze would have
12441244
options->extra_tserver_flags.push_back("--ysql_enable_auto_analyze=false");
12451245
options->extra_tserver_flags.push_back("--ysql_yb_user_ddls_preempt_auto_analyze=true");
1246+
// The test verifies a long ANALYZE can be interrupted by another DDL. However, table lock
1247+
// prevents this so we're disabling it to keep the test's original intent.
1248+
options->extra_tserver_flags.emplace_back(
1249+
"--allowed_preview_flags_csv=enable_object_locking_for_table_locks");
1250+
options->extra_tserver_flags.emplace_back("--enable_object_locking_for_table_locks=false");
12461251
ANNOTATE_UNPROTECTED_WRITE(FLAGS_vmodule) = "libpqutils*=1";
12471252
}
12481253
};

0 commit comments

Comments
 (0)