Skip to content

Commit 2017ce0

Browse files
committed
[#28879][#28726] YSQL: Disable txn ddl and object locking in pg_partman-test
Summary: While porting pg_partman in YSQL, we assumed that transactional ddl support doesn't exist. There are some non-trivial changes that need to be made to support transactional ddl with pg_partman. So this revision disables txn ddl and object lock (since it depends on txn ddl) in pg_partman-test. #28726 will be used to track the relevant work required to support txn ddl with pg_partman. Jira: DB-18601, DB-18425 Test Plan: Jenkins: test regex: .*PgPartmanTest.* ./yb_build.sh --cxx-test integration-tests_pg_partman-test Reviewers: myang, bkolagani, rthallam Reviewed By: bkolagani Subscribers: yql Differential Revision: https://phorge.dev.yugabyte.com/D47399
1 parent 1564c6d commit 2017ce0

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/yb/integration-tests/pg_partman-test.cc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,12 @@ class PgPartmanTest : public MiniClusterTestWithClient<ExternalMiniCluster> {
3333
opts.enable_ysql = true;
3434
// (Auto Analyze #28389)
3535
opts.extra_tserver_flags.push_back("--ysql_enable_auto_analyze=false");
36+
// TODO(#28726): Reenable once pg_partman supports transactional ddl.
37+
opts.extra_tserver_flags.push_back("--ysql_yb_ddl_transaction_block_enabled=false");
38+
opts.extra_tserver_flags.push_back("--enable_object_locking_for_table_locks=false");
39+
opts.extra_tserver_flags.push_back(
40+
Format("--allowed_preview_flags_csv=$0,$1",
41+
"enable_object_locking_for_table_locks", "ysql_yb_ddl_transaction_block_enabled"));
3642

3743
cluster_.reset(new ExternalMiniCluster(opts));
3844
ASSERT_OK(cluster_->Start());

0 commit comments

Comments
 (0)