[#24523] YSQL: Move pg_cron out or preview

Summary:
Convert to normal gFlag instead of Preview.
Flag is still kept OFF by default, since turning it on will case pg_cron launcher to run even if the extension is not created by the user.

Fixes #24523
Jira: DB-13555

Test Plan: Jenkins

Reviewers: tnayak, fizaa, slingam

Reviewed By: slingam

Subscribers: ybase

Differential Revision: https://phorge.dev.yugabyte.com/D39212

Author: hari90

java/yb-pgsql/src/test/java/org/yb/pgsql/TestPgRegressThirdPartyExtensionsPgCron.java

@@ -30,7 +30,6 @@ public int getTestMethodTimeoutSec() {
   @Override
   protected Map<String, String> getMasterFlags() {
     Map<String, String> flagMap = super.getMasterFlags();
-    flagMap.put("allowed_preview_flags_csv", "enable_pg_cron");
     flagMap.put("enable_pg_cron", "true");
     return flagMap;
   }
@@ -39,11 +38,7 @@ protected Map<String, String> getMasterFlags() {
   protected Map<String, String> getTServerFlags() {
     Map<String, String> flagMap = super.getTServerFlags();
     if (isTestRunningWithConnectionManager()) {
-      flagMap.put("allowed_preview_flags_csv",
-            "enable_pg_cron,enable_ysql_conn_mgr");
-    }
-    else {
-      flagMap.put("allowed_preview_flags_csv", "enable_pg_cron");
+      flagMap.put("allowed_preview_flags_csv", "enable_ysql_conn_mgr");
     }
     flagMap.put("enable_pg_cron", "true");
     return flagMap;

src/yb/common/common_flags.cc

@@ -195,13 +195,6 @@ DEFINE_RUNTIME_AUTO_bool(enable_xcluster_auto_flag_validation, kLocalPersisted,
 DEFINE_RUNTIME_AUTO_PG_FLAG(bool, yb_enable_ddl_atomicity_infra, kLocalPersisted, false, true,
     "Enables YSQL DDL atomicity");
 
-// NOTE: This flag guards proto changes and it is not safe to enable during an upgrade, or rollback
-// once enabled. If you want to change the default to true then you will have to make it a
-// kLocalPersisted AutoFlag.
-DEFINE_NON_RUNTIME_PREVIEW_bool(enable_pg_cron, false,
-    "Enables the pg_cron extension. Jobs will be run on a single tserver node. The node should be "
-    "assumed to be selected randomly.");
-
 DEFINE_NON_RUNTIME_string(certs_for_cdc_dir, "",
     "The parent directory of where all certificates for xCluster source universes will "
     "be stored, for when the source and target universes use different certificates. "

src/yb/integration-tests/pg_cron-test.cc

@@ -53,11 +53,9 @@ class PgCronTest : public MiniClusterTestWithClient<ExternalMiniCluster> {
     opts.num_masters = 1;
     opts.enable_ysql = true;
 
-    opts.extra_master_flags.push_back("--allowed_preview_flags_csv=enable_pg_cron");
     opts.extra_master_flags.push_back("--enable_pg_cron=true");
 
     opts.extra_tserver_flags.push_back("--vmodule=pg_cron*=4");
-    opts.extra_tserver_flags.push_back("--allowed_preview_flags_csv=enable_pg_cron");
     opts.extra_tserver_flags.push_back("--enable_pg_cron=true");
     opts.extra_tserver_flags.push_back(
         Format("--ysql_pg_conf_csv=cron.yb_job_list_refresh_interval=$0", kJobListRefreshInterval));

src/yb/server/server_common_flags.cc

@@ -20,3 +20,10 @@
 // Changing the value after setup is not recommended.
 DEFINE_NON_RUNTIME_string(cluster_uuid, "", "Cluster UUID to be used by this cluster");
 TAG_FLAG(cluster_uuid, hidden);
+
+// NOTE: This flag guards proto changes and it is not safe to enable during an upgrade, or rollback
+// once enabled. If you want to change the default to true then you will have to make it a
+// kLocalPersisted AutoFlag.
+DEFINE_NON_RUNTIME_bool(enable_pg_cron, false,
+    "Enables the pg_cron extension. Jobs will be run on a single tserver node. The node should be "
+    "assumed to be selected randomly.");