[#28706] YSQL: run yb_pgindent

Summary:
1. Refactor code in YbRunWithPrefetcher to set
   YbcPgLastKnownCatalogVersionInfo fields one by one rather than
   assigning the whole struct.  This is to avoid error on running
   yb_pgindent.
1. Update yb_typedefs.list using the method described in
   src/postgres/src/tools/pgindent/README.
1. Run yb_pgindent.
1. Make manual adjustments to some areas badly affected by yb_pgindent:

   - Add "YB" to comment in pgss_store.
   - Rename local variable is_tidvar to yb_is_tidvar in IsCTIDVar, and
     do other adjustments in the area.
   - Move function parameter comment after ");" for InitPostgres
     function call in PostgresMain.
   - YbctidListEval has a function call breaking after "(": restructure
     it.
   - yb_xcluster_ddl_replication/source_ddl_end_handler.h doesn't have
     "extern" for function declarations.  Add it.  There are probably
     more violations in other files in this directory, but don't bother
     with it now since they are not affected by this yb_pgindent run.

1. Run yb_pgindent one more time.

Jira: DB-18409

Test Plan:
jenkins

Close: #28706

Reviewers: myang, asaha, amartsinchyk, hsunder

Reviewed By: myang, asaha

Subscribers: yql

Differential Revision: https://phorge.dev.yugabyte.com/D46798

Author: jaki

src/postgres/contrib/pg_stat_statements/pg_stat_statements.c

@@ -2002,10 +2002,14 @@ pgss_store(const char *query, uint64 queryId,
 			e->counters.jit_emission_time += INSTR_TIME_GET_MILLISEC(jitusage->emission_counter);
 		}
 
-		/* These stats are collected for both regular and utility statements, unlike EXPLAIN */
+		/*
+		 * YB: These stats are collected for both regular and utility
+		 * statements, unlike EXPLAIN
+		 */
 		if (kind == PGSS_EXEC)
 		{
 			YbInstrumentation yb_instr = {0};
+
 			YbUpdateSessionStats((YbInstrumentation *) &yb_instr);
 			e->counters.yb_counters.counters[YB_INT_DOCDB_READ_RPCS] +=
 				yb_instr.tbl_reads.count + yb_instr.index_reads.count;
@@ -2022,7 +2026,7 @@ pgss_store(const char *query, uint64 queryId,
 				(yb_instr.catalog_reads.wait_time) / 1000000.0;
 			e->counters.yb_counters.counters_dbl[YB_DBL_DOCDB_WAIT_TIME_MS] +=
 				(yb_instr.tbl_reads.wait_time + yb_instr.write_flushes.wait_time +
-				yb_instr.index_reads.wait_time) / 1000000.0;
+				 yb_instr.index_reads.wait_time) / 1000000.0;
 		}
 
 		SpinLockRelease(&e->mutex);

src/postgres/src/backend/access/transam/parallel.c

@@ -1467,6 +1467,7 @@ ParallelWorkerMain(Datum main_arg)
 			.parallel_leader_session_id = &fps->parallel_master_yb_session_state.session_id,
 			.shared_data = &fps->parallel_leader_pgproc->yb_shared_data
 		};
+
 		YbBackgroundWorkerInitializeConnectionByOid(fps->database_id,
 													fps->authenticated_user_id,
 													BGWORKER_BYPASS_ALLOWCONN,

src/postgres/src/backend/access/transam/xact.c

@@ -2130,31 +2130,32 @@ YBBuildInitTransactionData()
 	return (YbcPgInitTransactionData)
 	{
 		.xact_start_timestamp = xactStartTimestamp,
-		.xact_read_only = XactReadOnly,
-		.xact_deferrable = XactDeferrable,
-		.enable_tracing = YBEnableTracing(),
-		.effective_pggate_isolation_level = YBGetEffectivePggateIsolationLevel(),
-		.read_from_followers_enabled = YBReadFromFollowersEnabled(),
-		.follower_read_staleness_ms = YBFollowerReadStalenessMs()
+			.xact_read_only = XactReadOnly,
+			.xact_deferrable = XactDeferrable,
+			.enable_tracing = YBEnableTracing(),
+			.effective_pggate_isolation_level = YBGetEffectivePggateIsolationLevel(),
+			.read_from_followers_enabled = YBReadFromFollowersEnabled(),
+			.follower_read_staleness_ms = YBFollowerReadStalenessMs()
 	};
 }
 
 static void
-YBRunWithInitTransactionData(YbcStatus (*Callback)(const YbcPgInitTransactionData *))
+YBRunWithInitTransactionData(YbcStatus (*Callback) (const YbcPgInitTransactionData *))
 {
 	if (YBTransactionsEnabled())
 	{
 		const YbcPgInitTransactionData data =
-			{
-				.xact_start_timestamp = xactStartTimestamp,
-				.xact_read_only = XactReadOnly,
-				.xact_deferrable = XactDeferrable,
-				.enable_tracing = YBEnableTracing(),
-				.effective_pggate_isolation_level = YBGetEffectivePggateIsolationLevel(),
-				.read_from_followers_enabled = YBReadFromFollowersEnabled(),
-				.follower_read_staleness_ms = YBFollowerReadStalenessMs()
-			};
-		HandleYBStatus((*Callback)(&data));
+		{
+			.xact_start_timestamp = xactStartTimestamp,
+			.xact_read_only = XactReadOnly,
+			.xact_deferrable = XactDeferrable,
+			.enable_tracing = YBEnableTracing(),
+			.effective_pggate_isolation_level = YBGetEffectivePggateIsolationLevel(),
+			.read_from_followers_enabled = YBReadFromFollowersEnabled(),
+			.follower_read_staleness_ms = YBFollowerReadStalenessMs()
+		};
+
+		HandleYBStatus((*Callback) (&data));
 	}
 }
 

src/postgres/src/backend/catalog/pg_publication.c

@@ -1047,11 +1047,12 @@ YBGetPublicationOidsByNames(List *pubnames)
 
 	yb_publications = YBGetPublicationsByNames(pubnames, false /* missing_ok */ );
 
-	size_t table_idx = 0;
+	size_t		table_idx = 0;
 
-	foreach (lc, yb_publications)
+	foreach(lc, yb_publications)
 	{
 		Publication *pub = (Publication *) lfirst(lc);
+
 		result[table_idx++] = pub->oid;
 	}
 

src/postgres/src/backend/commands/copyfrom.c

@@ -798,12 +798,13 @@ CopyFrom(CopyFromState cstate)
 		else if (IsTransactionBlock() || YbIsBatchedExecution())
 		{
 			const char *context = IsTransactionBlock() ? "transaction block" : "batch of commands";
+
 			ereport(WARNING,
 					(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
 					 errmsg("ROWS_PER_TRANSACTION is not supported in a %s", context),
 					 errdetail("Defaulting to using one transaction for all statements in the %s.", context),
 					 errhint("Either run this COPY outside of a %s or set rows_per_transaction option to `0` "
-							" to remove this warning.", context)));
+							 " to remove this warning.", context)));
 		}
 		else if (HasNonRITrigger(cstate->rel->trigdesc))
 			ereport(WARNING,

src/postgres/src/backend/commands/dbcommands.c

@@ -1105,8 +1105,8 @@ createdb(ParseState *pstate, const CreatedbStmt *stmt)
 	 * getting dropped while this operation is in progress.
 	 */
 	bool		is_clone = strcmp(dbtemplate, "template0") != 0 && strcmp(dbtemplate, "template1") != 0;
-	LOCKMODE    lockmode_srcdb = (is_clone ? AccessShareLock : ShareLock);
-	LOCKMODE    lockmode_rel_db = (is_clone ? AccessShareLock : RowExclusiveLock);
+	LOCKMODE	lockmode_srcdb = (is_clone ? AccessShareLock : ShareLock);
+	LOCKMODE	lockmode_rel_db = (is_clone ? AccessShareLock : RowExclusiveLock);
 
 	if (!get_db_info(dbtemplate, lockmode_srcdb,
 					 &src_dboid, &src_owner, &src_encoding,

src/postgres/src/backend/commands/explain.c

@@ -722,9 +722,10 @@ const char *yb_metric_event_label[] = {
 
 #undef BUILD_METRIC_LABEL
 
-typedef struct {
-	bool is_required;
-	bool is_dist;
+typedef struct
+{
+	bool		is_required;
+	bool		is_dist;
 	ExplainFormat format;
 } YbExplainCommitStatState;
 
@@ -1174,7 +1175,7 @@ YbExplainCommitStats(DestReceiver *dest)
 
 	ExplainState *es = NewExplainState();
 	TupOutputState *tstate = NULL;
-	TupleDesc tupdesc;
+	TupleDesc	tupdesc;
 	YbInstrumentation yb_instr = {0};
 
 	es->rpc = yb_explain_commit_stat_state.is_dist;

src/postgres/src/backend/commands/tablecmds.c

@@ -1956,7 +1956,7 @@ ExecuteTruncate(TruncateStmt *stmt, bool yb_is_top_level, List **yb_relids)
 	List	   *relids = NIL;
 	List	   *relids_logged = NIL;
 	ListCell   *cell;
-	bool yb_only_temp_tables = true;
+	bool		yb_only_temp_tables = true;
 
 	/*
 	 * Open, exclusive-lock, and check all the explicitly-specified relations
@@ -3728,7 +3728,7 @@ SetRelationTableSpace(Relation rel,
 	otid = tuple->t_self;
 	rd_rel = (Form_pg_class) GETSTRUCT(tuple);
 
-	Oid yb_old_reltablespace = rd_rel->reltablespace;
+	Oid			yb_old_reltablespace = rd_rel->reltablespace;
 
 	/* Update the pg_class row. */
 	rd_rel->reltablespace = (newTableSpaceId == MyDatabaseTableSpace) ?
@@ -3779,25 +3779,27 @@ SetRelationTableSpace(Relation rel,
 	{
 		List	   *indexIds = RelationGetIndexList(rel);
 		ListCell   *lc;
-		Oid newPrimaryKeyTableSpaceId = (newTableSpaceId == MyDatabaseTableSpace) ?
+		Oid			newPrimaryKeyTableSpaceId = (newTableSpaceId == MyDatabaseTableSpace) ?
 			InvalidOid : newTableSpaceId;
 
 		foreach(lc, indexIds)
 		{
 			Oid			idxOid = lfirst_oid(lc);
 			Relation	idxRel = RelationIdGetRelation(idxOid);
 			bool		isPrimaryIndex = (idxRel != NULL &&
-										 idxRel->rd_index &&
-										 idxRel->rd_index->indisprimary);
+										  idxRel->rd_index &&
+										  idxRel->rd_index->indisprimary);
+
 			RelationClose(idxRel);
 
 			if (!isPrimaryIndex)
 				continue;
 
 			Relation	idx_pg_class = table_open(RelationRelationId,
-													RowExclusiveLock);
+												  RowExclusiveLock);
 			HeapTuple	idx_tuple = SearchSysCacheCopy1(RELOID,
-													ObjectIdGetDatum(idxOid));
+														ObjectIdGetDatum(idxOid));
+
 			if (!HeapTupleIsValid(idx_tuple))
 				elog(ERROR, "cache lookup failed for relation %u", idxOid);
 			Form_pg_class idx_rd_rel = (Form_pg_class) GETSTRUCT(idx_tuple);
@@ -3809,7 +3811,7 @@ SetRelationTableSpace(Relation rel,
 
 			/* Update PK's pg_shdepend entry */
 			changeDependencyOnTablespace(RelationRelationId, idxOid,
-				newPrimaryKeyTableSpaceId);
+										 newPrimaryKeyTableSpaceId);
 
 			heap_freetuple(idx_tuple);
 			table_close(idx_pg_class, RowExclusiveLock);

src/postgres/src/backend/executor/nodeTidscan.c

@@ -368,14 +368,14 @@ YbctidListEval(TidScanState *tidstate)
 			int			i;
 
 			arraydatum = ExecEvalExprSwitchContext(tidexpr->exprstate,
-													econtext,
-													&isNull);
+												   econtext,
+												   &isNull);
 			if (isNull)
 				continue;
 
 			itemarray = DatumGetArrayTypeP(arraydatum);
 			deconstruct_array(itemarray, BYTEAOID, -1, false, TYPALIGN_INT,
-								&ipdatums, &ipnulls, &ndatums);
+							  &ipdatums, &ipnulls, &ndatums);
 			if (numYbctids + ndatums > numAllocYbctids)
 			{
 				numAllocYbctids = numYbctids + ndatums;
@@ -427,8 +427,9 @@ YbctidListEval(TidScanState *tidstate)
 static int
 ybctid_comparator(const void *a, const void *b)
 {
-	return DatumGetInt32(
-		DirectFunctionCall2(byteacmp, *(const Datum *) a, *(const Datum *) b));
+	return DatumGetInt32(DirectFunctionCall2(byteacmp,
+											 *(const Datum *) a,
+											 *(const Datum *) b));
 }
 
 /* ----------------------------------------------------------------
@@ -545,23 +546,25 @@ YbTidNext(TidScanState *node)
 	 */
 	if (node->ss.ss_currentScanDesc == NULL)
 	{
-		TidScan *plan = (TidScan *) node->ss.ps.plan;
+		TidScan    *plan = (TidScan *) node->ss.ps.plan;
 		YbPushdownExprs *rel_pushdown =
 			YbInstantiatePushdownExprs(&plan->yb_rel_pushdown, estate);
+
 		if (node->yb_tss_aggrefs)
 		{
 			TupleDesc	tupdesc = CreateTemplateTupleDesc(list_length(node->yb_tss_aggrefs));
+
 			ExecInitScanTupleSlot(node->ss.ps.state, &node->ss, tupdesc, &TTSOpsVirtual);
 			slot = node->ss.ss_ScanTupleSlot;
 		}
 		ybScan = ybcBeginScan(node->ss.ss_currentRelation,
-							  NULL,	/* index */
+							  NULL, /* index */
 							  false,	/* xs_want_itup */
 							  0,	/* nkeys */
 							  NULL, /* key */
 							  (Scan *) plan,
 							  rel_pushdown,
-							  NULL,	/* idx_pushdown */
+							  NULL, /* idx_pushdown */
 							  node->yb_tss_aggrefs,
 							  0,	/* distinct_prefixlen */
 							  &estate->yb_exec_params,
@@ -751,8 +754,8 @@ ExecInitTidScan(TidScan *node, EState *estate, int eflags)
 	ExecInitScanTupleSlot(estate, &tidstate->ss,
 						  RelationGetDescr(currentRelation),
 						  IsYBRelation(currentRelation) ?
-							  &TTSOpsVirtual :
-							  table_slot_callbacks(currentRelation));
+						  &TTSOpsVirtual :
+						  table_slot_callbacks(currentRelation));
 
 	/*
 	 * Initialize result type and projection.

src/postgres/src/backend/executor/nodeYbBitmapTablescan.c

@@ -264,9 +264,9 @@ CreateYbBitmapTableScanDesc(YbBitmapTableScanState *scanstate)
 		plan.recheck_local_quals = NULL;
 
 	yb_pushdown = YbInstantiatePushdownExprs((scanstate->work_mem_exceeded ?
-											   &plan.fallback_pushdown :
-											   &plan.rel_pushdown),
-											  scanstate->ss.ps.state);
+											  &plan.fallback_pushdown :
+											  &plan.rel_pushdown),
+											 scanstate->ss.ps.state);
 
 
 	ybScan = ybcBeginScan(scanstate->ss.ss_currentRelation,
@@ -295,7 +295,7 @@ CreateYbBitmapTableScanDesc(YbBitmapTableScanState *scanstate)
 	if (scanstate->recheck_required && !scanstate->work_mem_exceeded)
 	{
 		YbPushdownExprs *recheck_pushdown = YbInstantiatePushdownExprs(&plan.recheck_pushdown,
-																		scanstate->ss.ps.state);
+																	   scanstate->ss.ps.state);
 
 		if (recheck_pushdown)
 		{