Skip to content

Commit d3aa7d8

Browse files
committed
Bump liger-kernel minimum version to 0.7.0
liger-kernel v0.7.0 has been released with vllm_is_ratio support (linkedin/Liger-Kernel#1088), so pin to this version as minimum and remove the provisional xfail marker on the vllm_is_ratio test.
1 parent 2434ca7 commit d3aa7d8

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ kernels = [
5858
"kernels"
5959
]
6060
liger = [
61-
"liger-kernel>=0.6.4"
61+
"liger-kernel>=0.7.0"
6262
]
6363
peft = [
6464
"peft>=0.8.0"
@@ -108,7 +108,7 @@ dev = [
108108
# kernels
109109
"kernels",
110110
# liger
111-
"liger-kernel>=0.6.4",
111+
"liger-kernel>=0.7.0",
112112
# peft
113113
"peft>=0.8.0",
114114
# quality

tests/test_grpo_trainer.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -989,11 +989,6 @@ def test_training_with_off_policy_mask_with_liger(self):
989989
assert not torch.equal(param, new_param), f"Parameter {n} has not changed."
990990

991991
@require_liger_kernel
992-
@pytest.mark.xfail(
993-
not is_liger_kernel_available(min_version="0.6.6"),
994-
reason="Requires vllm_is_ratio support in liger-kernel >= 0.6.6 (linkedin/Liger-Kernel#1088)",
995-
strict=True,
996-
)
997992
def test_compute_liger_loss_passes_vllm_is_ratio(self):
998993
"""Test that importance_sampling_ratio from inputs is passed to liger_grpo_loss as vllm_is_ratio."""
999994
dataset = load_dataset("trl-internal-testing/zen", "standard_prompt_only", split="train")

trl/import_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
from transformers.utils.import_utils import _is_package_available
2525

2626

27-
LIGER_KERNEL_MIN_VERSION = "0.6.4"
27+
LIGER_KERNEL_MIN_VERSION = "0.7.0"
2828

2929

3030
def is_deepspeed_available() -> bool:

0 commit comments

Comments
 (0)