fix(region,glance,host-deployer): guest image support bios boot mode detect (#23376)

Author: wanyaoqi

pkg/apis/image/consts.go

@@ -62,6 +62,7 @@ const (
 	IMAGE_OS_VERSION           = "os_version"
 	IMAGE_DISK_FORMAT          = "disk_format"
 	IMAGE_UEFI_SUPPORT         = "uefi_support"
+	IMAGE_BIOS_SUPPORT         = "bios_support"
 	IMAGE_IS_LVM_PARTITION     = "is_lvm_partition"
 	IMAGE_IS_READONLY          = "is_readonly"
 	IMAGE_PARTITION_TYPE       = "partition_type"

pkg/compute/models/guests.go

@@ -1798,26 +1798,40 @@ func (manager *SGuestManager) validateCreateData(
 
 		if imageDiskFormat != "iso" {
 			var imgSupportUEFI *bool
+			var imgSupportBIOS *bool
 			if desc, ok := imgProperties[imageapi.IMAGE_UEFI_SUPPORT]; ok {
 				support := desc == "true"
 				imgSupportUEFI = &support
 			}
+			if biosDesc, ok := imgProperties[imageapi.IMAGE_BIOS_SUPPORT]; ok {
+				supportBIOS := biosDesc == "true"
+				imgSupportBIOS = &supportBIOS
+			}
+			// uefi is not support set default support bios
+			if imgSupportUEFI == nil || !*imgSupportUEFI {
+				supportBIOS := true
+				imgSupportBIOS = &supportBIOS
+			}
+
 			if input.OsArch == apis.OS_ARCH_AARCH64 {
 				// arm image supports UEFI by default
 				support := true
 				imgSupportUEFI = &support
 			}
-			switch {
-			case imgSupportUEFI != nil && *imgSupportUEFI:
-				if len(input.Bios) == 0 {
-					input.Bios = "UEFI"
-				} else if input.Bios != "UEFI" {
-					return nil, httperrors.NewInputParameterError("UEFI image requires UEFI boot mode")
+			switch input.Bios {
+			case "UEFI":
+				if imgSupportUEFI == nil || !*imgSupportUEFI {
+					return nil, httperrors.NewInputParameterError("UEFI boot mode requires UEFI image")
+				}
+			case "BIOS":
+				if imgSupportBIOS == nil || !*imgSupportBIOS {
+					return nil, httperrors.NewInputParameterError("BIOS boot mode requires BIOS image")
 				}
 			default:
-				// not UEFI image
-				if input.Bios == "UEFI" && len(imgProperties) != 0 {
-					return nil, httperrors.NewInputParameterError("UEFI boot mode requires UEFI image")
+				if imgSupportUEFI != nil && *imgSupportUEFI {
+					input.Bios = "UEFI"
+				} else {
+					input.Bios = "BIOS"
 				}
 			}
 		}

pkg/hostman/diskutils/deploy_iface/deployer.go

@@ -34,6 +34,7 @@ type IDeployer interface {
 	MountRootfs(readonly bool) (fsdriver.IRootFsDriver, error)
 	UmountRootfs(fd fsdriver.IRootFsDriver) error
 	DetectIsUEFISupport(rootfs fsdriver.IRootFsDriver) bool
+	DetectIsBIOSSupport(rootfs fsdriver.IRootFsDriver) bool
 
 	DeployGuestfs(req *apis.DeployParams) (res *apis.DeployGuestFsResponse, err error)
 	ResizeFs(req *apis.ResizeFsParams) (res *apis.Empty, err error)

pkg/hostman/diskutils/fsutils/fsutils.go

@@ -15,7 +15,10 @@
 package fsutils
 
 import (
+	"bufio"
+	"bytes"
 	"fmt"
+	"os"
 	"regexp"
 	"strconv"
 	"strings"
@@ -547,6 +550,63 @@ func DetectIsUEFISupport(rootfs fsdriver.IRootFsDriver, partitions []fsdriver.ID
 	return false
 }
 
+func DetectIsBIOSSupport(partDev string, rootfs fsdriver.IRootFsDriver) bool {
+	fi, err := os.OpenFile(partDev, os.O_RDONLY, 0444)
+	if err != nil {
+		log.Errorf("failed open partdev %s: %s", partDev, err)
+		return false
+	}
+	defer fi.Close()
+
+	// read first sector
+	sector := make([]byte, 512)
+	n, err := fi.Read(sector)
+	if err != nil || n != 512 {
+		log.Errorf("failed read first sector %d %s: %s", n, partDev, err)
+		return false
+	}
+
+	bootSignature := sector[510:512]
+	expectedSignature := []byte{0x55, 0xAA}
+	log.Infof("Detect is bios support bootSignature: %x", bootSignature)
+	if bootSignature[0] != expectedSignature[0] || bootSignature[1] != expectedSignature[1] {
+		return false
+	}
+	partitionType := rootfs.GetPartition().GetPhysicalPartitionType()
+	if partitionType == "mbr" {
+		return true
+	} else if partitionType == "gpt" {
+		/*
+			   Number  Start (sector)    End (sector)  Size       Code  Name
+			      1          227328        83886046   39.9 GiB    8300
+			     14            2048           10239   4.0 MiB     EF02
+			     15           10240          227327   106.0 MiB   EF00
+
+				# EF02 is BIOS Boot partition
+		*/
+		out, err := procutils.NewCommand("sgdisk", "-p", partDev).Output()
+		if err != nil {
+			log.Errorf("sgdisk -p %s failed: %s, %s", partDev, err, out)
+			return false
+		}
+		re := regexp.MustCompile(`^\s*(\d+)\s+(\d+)\s+(\d+)\s+([\d\.]+\s+\w+)\s+(\w+)\s*(.*)$`)
+		scanner := bufio.NewScanner(bytes.NewReader(out))
+		for scanner.Scan() {
+			line := scanner.Text()
+			m := re.FindStringSubmatch(line)
+			if m == nil {
+				continue
+			}
+			code := m[5]
+			if code == "EF02" {
+				return true
+			}
+		}
+	}
+
+	return false
+}
+
 func MountRootfs(readonly bool, partitions []fsdriver.IDiskPartition) (fsdriver.IRootFsDriver, error) {
 	errs := []error{}
 	for i := 0; i < len(partitions); i++ {
@@ -706,6 +766,7 @@ func ProbeImageInfo(d deploy_iface.IDeployer) (*apis.ImageInfo, error) {
 	// multi partition concurrent, so we need umount rootfs first
 	imageInfo.IsUefiSupport = d.DetectIsUEFISupport(rootfs)
 	imageInfo.PhysicalPartitionType = partition.GetPhysicalPartitionType()
+	imageInfo.IsBiosSupport = d.DetectIsBIOSSupport(rootfs)
 	log.Infof("ProbeImageInfo response %s", imageInfo)
 	return imageInfo, nil
 }

pkg/hostman/diskutils/libguestfs/driver.go

@@ -256,6 +256,10 @@ func (d *SLibguestfsDriver) DetectIsUEFISupport(rootfs fsdriver.IRootFsDriver) b
 	return fsutils.DetectIsUEFISupport(rootfs, d.GetPartitions())
 }
 
+func (d *SLibguestfsDriver) DetectIsBIOSSupport(rootfs fsdriver.IRootFsDriver) bool {
+	return fsutils.DetectIsBIOSSupport(d.nbddev, rootfs)
+}
+
 func (d *SLibguestfsDriver) MountRootfs(readonly bool) (fsdriver.IRootFsDriver, error) {
 	return fsutils.MountRootfs(readonly, d.GetPartitions())
 }

pkg/hostman/diskutils/nbd/driver.go

@@ -267,6 +267,10 @@ func (d *NBDDriver) DetectIsUEFISupport(rootfs fsdriver.IRootFsDriver) bool {
 	return fsutils.DetectIsUEFISupport(rootfs, d.GetPartitions())
 }
 
+func (d *NBDDriver) DetectIsBIOSSupport(rootfs fsdriver.IRootFsDriver) bool {
+	return fsutils.DetectIsBIOSSupport(d.nbdDev, rootfs)
+}
+
 func (d *NBDDriver) MountRootfs(readonly bool) (fsdriver.IRootFsDriver, error) {
 	return fsutils.MountRootfs(readonly, d.GetPartitions())
 }

pkg/hostman/diskutils/qemu_kvm/driver.go

@@ -380,6 +380,10 @@ func (d *QemuKvmDriver) DetectIsUEFISupport(rootfs fsdriver.IRootFsDriver) bool
 	return false
 }
 
+func (d *QemuKvmDriver) DetectIsBIOSSupport(rootfs fsdriver.IRootFsDriver) bool {
+	return false
+}
+
 func (d *QemuKvmDriver) MountRootfs(readonly bool) (fsdriver.IRootFsDriver, error) {
 	return nil, nil
 }

pkg/hostman/diskutils/qemu_kvm/local_driver.go

@@ -110,6 +110,10 @@ func (d *LocalDiskDriver) DetectIsUEFISupport(rootfs fsdriver.IRootFsDriver) boo
 	return fsutils.DetectIsUEFISupport(rootfs, d.GetPartitions())
 }
 
+func (d *LocalDiskDriver) DetectIsBIOSSupport(rootfs fsdriver.IRootFsDriver) bool {
+	return fsutils.DetectIsBIOSSupport("/dev/sda", rootfs)
+}
+
 func (d *LocalDiskDriver) MountRootfs(readonly bool) (fsdriver.IRootFsDriver, error) {
 	return fsutils.MountRootfs(readonly, d.GetPartitions())
 }

pkg/hostman/guestfs/fsdriver/linux.go

@@ -752,27 +752,26 @@ func (l *sLinuxRootFs) DetectIsUEFISupport(part IDiskPartition) bool {
 	// ref: https://wiki.archlinux.org/title/EFI_system_partition#Check_for_an_existing_partition
 	// To confirm this is the ESP, mount it and check whether it contains a directory named EFI,
 	// if it does this is definitely the ESP.
-	efiDir := "/EFI"
-	exits := part.Exists(efiDir, false)
-	if !exits {
-		return false
-	}
-
 	hasEFIFirmware := false
 
-	l.dirWalk(part, efiDir, func(path string, isDir bool) bool {
-		if isDir {
-			return false
-		}
-		// check file is UEFI firmware
-		if strings.HasSuffix(path, ".efi") {
-			log.Infof("EFI firmware %s found", path)
-			hasEFIFirmware = true
-			return true
+	for _, efiDir := range []string{"/EFI", "/efi"} {
+		if !part.Exists(efiDir, false) {
+			continue
 		}
-		// continue walk
-		return false
-	})
+		l.dirWalk(part, efiDir, func(path string, isDir bool) bool {
+			if isDir {
+				return false
+			}
+			// check file is UEFI firmware
+			if strings.HasSuffix(path, ".efi") {
+				log.Infof("EFI firmware %s found", path)
+				hasEFIFirmware = true
+				return true
+			}
+			// continue walk
+			return false
+		})
+	}
 
 	return hasEFIFirmware
 }

pkg/hostman/guestfs/kvmpart/kvmpart.go

@@ -70,6 +70,8 @@ func (p *SKVMGuestDiskPartition) GetPhysicalPartitionType() string {
 	idxP := strings.LastIndexByte(dev, 'p')
 	if idxP > 0 {
 		dev = dev[:idxP]
+	} else {
+		dev = strings.TrimRight(dev, "0123456789")
 	}
 	cmd := fmt.Sprintf(`fdisk -l %s | grep "Disk.*label type:"`, dev)
 	output, err := procutils.NewCommand("sh", "-c", cmd).Output()