Stop using open

Author: s-h-a-d-o-w

README.md

@@ -98,6 +98,7 @@ to port 5522 and killing it.
 Contributions welcome, as always. 🙂
 
 - To support more recent node versions, the `nan` dependency in `os-version` would have to be upgraded.
+- It would be nice to be able to move to ESM at some point. Unfortunately, dependencies with native aspects don't play well. At least not out of the box and it's not worthwhile to invest a lot of time into workarounds.
 - Refactor styles so there aren't as many inline ones.
 - Make ramping up/down times configurable.
 - Prettier status UI.

alfc.config.json

@@ -5,5 +5,5 @@
   "pl1": 37,
   "pl2": 106,
   "doFixedSpeed": false,
-  "fixedPercentage": 70
+  "fixedPercentage": 50
 }

bootstrap/esbuild.ts renamed to bootstrap/esbuild.mts

@@ -2,7 +2,7 @@ import esbuild, { Plugin } from "esbuild";
 import { getAbi } from "node-abi";
 import fs from "fs/promises";
 import path from "path";
-import { glob } from "glob";
+import fg from "fast-glob";
 
 interface PrebuildifyOptions {
   // CSV list of prebuildify targets. Combination of os.platform() and os.arch(), e.g. `win32-x64`.
@@ -34,7 +34,7 @@ const prebuildifyPlugin = ({
       const outPrebuilds = path.join(outdir, "prebuilds");
       await fs.mkdir(outPrebuilds, { recursive: true });
 
-      const prebuilds = await glob("node_modules/**/prebuilds/**/*.node");
+      const prebuilds = await fg(["node_modules/**/prebuilds/**/*.node"]);
 
       // Get target ABI version if specified
       const targets =
@@ -55,7 +55,8 @@ const prebuildifyPlugin = ({
       const parsedPlatforms = prebuildifyTargets?.split(",");
       for (const prebuild of prebuilds) {
         const filename = path.basename(prebuild);
-        const platform = path.dirname(prebuild).split(path.sep).pop();
+        // Seems like unlike glob, fast-glob always uses / instead of a OS specific path separator.
+        const platform = path.dirname(prebuild).split("/").pop();
 
         if (
           platform &&
@@ -85,7 +86,10 @@ await esbuild.build({
   bundle: true,
   platform: "node",
   target: "node22.11.0",
+  format: "cjs",
   outfile: "dist/index.js",
+  packages: "bundle",
+  external: ["./fancontrol"],
   plugins: [
     prebuildifyPlugin({
       prebuildifyTargets: "win32-x64",

bootstrap/index.ts

@@ -12,6 +12,11 @@ const sudoOptions = {
   name: "Aorus Laptop Fan Control",
 };
 
+const openBrowser = () => {
+  const start = process.platform === "win32" ? "start" : "open";
+  require("child_process").exec(`${start} http://localhost:5522`);
+};
+
 const sudoOutputHandler: Parameters<(typeof sudo)["exec"]>[2] = (
   error,
   stdout,
@@ -70,9 +75,7 @@ switch (process.argv[2]) {
           }
 
           console.log("Done.");
-          import("open").then(({ default: open }) => {
-            open("http://localhost:5522");
-          });
+          openBrowser();
         });
       },
     );
@@ -102,7 +105,7 @@ switch (process.argv[2]) {
           throw error;
         }
 
-        console.log("Done.");
+        console.log("You can delete alfc now.");
       });
     });
     break;
@@ -116,9 +119,13 @@ switch (process.argv[2]) {
     // Need to redirect all output to a log file on Windows.
     // On Linux, it'll go to the systemd logs.
     if (isWindows) {
-      const access = fs.createWriteStream(path.join(__dirname, "service.log"));
+      const logStream = fs.createWriteStream(
+        path.join(__dirname, "service.log"),
+        { flags: "a" },
+      );
       // @ts-expect-error Undefined/null type mismatch: Type 'Error | null | undefined' is not assignable to type 'Error | undefined'.
-      process.stdout.write = process.stderr.write = access.write.bind(access);
+      process.stdout.write = process.stderr.write =
+        logStream.write.bind(logStream);
       process.on("uncaughtException", function (err) {
         console.error(err && err.stack ? err.stack : err);
       });
@@ -127,10 +134,7 @@ switch (process.argv[2]) {
     process.chdir(__dirname);
     process.env.NODE_ENV = "production";
 
-    new Promise((resolve) => {
-      setTimeout(resolve, Number.MAX_SAFE_INTEGER);
-    });
-    // require("./fancontrol");
+    require("./fancontrol");
     break;
   default:
     console.error("If you can read this, either you or I did something wrong.");

bootstrap/package.json

@@ -3,23 +3,21 @@
   "version": "1.0.0",
   "main": "index.ts",
   "license": "MIT",
-  "type": "module",
   "scripts": {
-    "build": "rimraf dist && pnpm tsx esbuild.ts",
+    "build": "rimraf dist && pnpm tsx esbuild.mts",
     "build:esfirsttry": "esbuild index.ts --bundle --platform=node --target=node22 --external:*.node --outfile=dist/index.cjs",
     "build:old": "rimraf dist && ncc build index.ts",
     "start": "tsx ."
   },
   "dependencies": {
     "@neuralegion/os-service": "^1.2.6",
-    "@vscode/sudo-prompt": "^9.3.1",
-    "open": "^10.1.0"
+    "@vscode/sudo-prompt": "^9.3.1"
   },
   "devDependencies": {
     "@types/node-abi": "^3.0.3",
     "@vercel/ncc": "0.38.3",
     "esbuild": "^0.24.2",
-    "glob": "^11.0.1",
+    "fast-glob": "^3.3.3",
     "node-abi": "^3.73.0",
     "rimraf": "6.0.1",
     "tsx": "^4.19.2"