Merge pull request #866 from yutailang0119/cleanup-ignore-warnings

Cleanup ignore warnings

Author: yutailang0119

README.md

@@ -37,8 +37,8 @@ jobs:
       - run: ./gradlew lint
       - uses: yutailang0119/action-android-lint@v3
         with:
-          ignore-warnings: true # Ignore Lint Warnings
           report-path: build/reports/*.xml # Support glob patterns by https://www.npmjs.com/package/@actions/glob
+          ignore-warnings: true # Ignore Lint Warnings
         continue-on-error: false # If annotations contain error of severity, action-android-lint exit 1.
 ```
 

action.yml

@@ -10,7 +10,7 @@ inputs:
     default: true
   ignore-warnings:
     description: 'Ignore Lint Warnings'
-    default: false    
+    default: false
 runs:
   using: 'node20'
   main: 'dist/index.js'

dist/index.js

@@ -6,10 +6,11 @@ import {parseXmls} from './parser'
 async function run(): Promise<void> {
   try {
     const reportPath = core.getInput('report-path', {required: true})
-    const ignoreWarnings = core.getBooleanInput('ignore-warnings')
     const globOptions = {
       followSymbolicLinks: core.getBooleanInput('follow-symbolic-links')
     }
+    const ignoreWarnings = core.getBooleanInput('ignore-warnings')
+
     const globber = await glob.create(reportPath, globOptions)
     const files = await globber.glob()
 

dist/index.js.map

@@ -28,9 +28,6 @@ export const parseXml = async (
       const annotations: Annotation[] = []
       for (const issueElement of xml.issues.issue) {
         const issue = issueElement.$
-        if (ignoreWarnings === true && issue.severity !== 'Error') {
-          continue
-        }
         for (const locationElement of issueElement.location) {
           const location = locationElement.$
 
@@ -44,7 +41,15 @@ export const parseXml = async (
           annotations.push(annotation)
         }
       }
-      resolve(annotations)
+      if (ignoreWarnings === true) {
+        resolve(
+          annotations.filter(annotation => {
+            return annotation.severityLevel !== 'warning'
+          })
+        )
+      } else {
+        resolve(annotations)
+      }
     } catch (error) {
       core.debug(`failed to read ${error}`)
     }