Skip to content

Commit 374b67b

Browse files
committed
Reduce text duplication in documentation
based on review. Thanks to @manics
1 parent 50cb222 commit 374b67b

File tree

1 file changed

+20
-29
lines changed

1 file changed

+20
-29
lines changed

docs/source/zero-to-binderhub/setup-binderhub.rst

Lines changed: 20 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -112,34 +112,11 @@ Create ``config.yaml``
112112

113113
Create a file called ``config.yaml``.
114114

115-
Exposing JupyterHub
116-
~~~~~~~~~~~~~~~~~~~
115+
Exposing JupyterHub and BinderHub
116+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
117117

118-
By default, JupyterHub is exposed as a ``LoadBalancer``.
119-
If you want to expose JupyterHub using an ingress controller,
120-
you need to add::
121-
122-
jupyterhub:
123-
proxy:
124-
service:
125-
type: ClusterIP
126-
ingress:
127-
enabled: true
128-
annotations:
129-
# replace with your ingress class
130-
kubernetes.io/ingress.class: "nginx"
131-
hosts:
132-
- jupyterhub.XXX.XXX.XXX.XXX.nip.io
133-
134-
The above snippet assumes that you are using `Ingress NGINX Controller <https://kubernetes.github.io/ingress-nginx/>`_
135-
and uses `nip.io <https://nip.io/>`_ to provide you with a temporary domain
136-
to the IP ``XXX.XXX.XXX.XXX``.
137-
138-
Exposing BinderHub
139-
~~~~~~~~~~~~~~~~~~
140-
141-
By default, BinderHub is exposed as ``LoadBalancer``.
142-
If you want to expose BinderHub using a ingress controller,
118+
By default, JupyterHub and BinderHub is exposed as a ``LoadBalancer``.
119+
If you want to expose JupyterHub and BinderHub using an ingress controller,
143120
you need to add::
144121

145122
service:
@@ -148,17 +125,31 @@ you need to add::
148125
ingress:
149126
enabled: true
150127
annotations:
151-
# use the shared ingress-nginx
128+
# replace with your ingress class
152129
kubernetes.io/ingress.class: "nginx"
153130
https:
154131
# This is unsafe! Only se for local development
155132
enabled: false
156133
hosts:
134+
# replace with your domain for BinderHub
157135
- binderhub.XXX.XXX.XXX.XXX.nip.io
158136

137+
jupyterhub:
138+
proxy:
139+
service:
140+
type: ClusterIP
141+
ingress:
142+
enabled: true
143+
annotations:
144+
# replace with your ingress class
145+
kubernetes.io/ingress.class: "nginx"
146+
hosts:
147+
# replace with your domain for JupyterHub
148+
- jupyterhub.XXX.XXX.XXX.XXX.nip.io
149+
159150
The above snippet assumes that you are using `Ingress NGINX Controller <https://kubernetes.github.io/ingress-nginx/>`_
160151
and uses `nip.io <https://nip.io/>`_ to provide you with a temporary domain
161-
to the IPv6 ``XXX.XXX.XXX.XXX``.
152+
to the IP ``XXX.XXX.XXX.XXX``.
162153

163154
Expand ``config.yaml``
164155
----------------------

0 commit comments

Comments
 (0)