Use .values() when using only values

yuvipanda · yuvipanda · commit c6d51e74ee02 · 2024-11-04T10:03:39.000-08:00
diff --git a/jupyter_server/serverapp.py b/jupyter_server/serverapp.py
@@ -2703,7 +2703,7 @@ def init_metrics(self) -> None:
         """
         SERVER_INFO.info({"version": __version__})
 
-        for k, ext in self.extension_manager.extensions.items():
+        for ext in self.extension_manager.extensions.values():
             SERVER_EXTENSION_INFO.labels(
                 name=ext.name, version=ext.version, enabled=str(ext.enabled).lower()
             )

Original file line number	Diff line number	Diff line change
`@@ -2703,7 +2703,7 @@ def init_metrics(self) -> None:`
`2703`	`2703`	`"""`
`2704`	`2704`	`SERVER_INFO.info({"version": __version__})`
`2705`	`2705`
`2706`		`- for k, ext in self.extension_manager.extensions.items():`
	`2706`	`+ for ext in self.extension_manager.extensions.values():`
`2707`	`2707`	`SERVER_EXTENSION_INFO.labels(`
`2708`	`2708`	`name=ext.name, version=ext.version, enabled=str(ext.enabled).lower()`
`2709`	`2709`	`)`