Skip to content

Commit 37ba129

Browse files
committed
Don't set a pre-build memory limit
Trying to fix https://jupyter.zulipchat.com/#narrow/channel/469744-jupyterhub/topic/try.20mybinder.20jupyterleab.20demo.20broken, which is breaking because mamba gets OOM killed. We have memory limits set on dind as a whole, and memory_limit for builds (in its current, per-build form) is going away as part of jupyterhub/repo2docker#1402 as well. So let's remove it and see.
1 parent 4cff375 commit 37ba129

File tree

4 files changed

+0
-4
lines changed

4 files changed

+0
-4
lines changed

config/hetzner-2i2c-bare.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ binderhub:
4040
# complicated: dind memory request + KubernetesBuildExecutor.memory_request * builds_per_node ~= node memory
4141
KubernetesBuildExecutor:
4242
memory_request: "2G"
43-
memory_limit: "4G"
4443
docker_host: /var/run/dind/docker.sock
4544
repo2docker_extra_args:
4645
# try to avoid timeout pushing to local registry

config/hetzner-2i2c.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ binderhub:
4040
# complicated: dind memory request + KubernetesBuildExecutor.memory_request * builds_per_node ~= node memory
4141
KubernetesBuildExecutor:
4242
memory_request: "2G"
43-
memory_limit: "4G"
4443
docker_host: /var/run/dind/docker.sock
4544
repo2docker_extra_args:
4645
# try to avoid timeout pushing to local registry

config/staging.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ binderhub:
1010
badge_base_url: https://staging.mybinder.org
1111
image_prefix: us-central1-docker.pkg.dev/binderhub-288415/staging/r2d-2023-04-
1212
sticky_builds: true
13-
build_memory_limit: "2G"
1413
DockerRegistry:
1514
token_url: "https://us-central1-docker.pkg.dev/v2/token"
1615

mybinder/values.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,6 @@ binderhub:
218218
}
219219
KubernetesBuildExecutor:
220220
build_image: quay.io/jupyterhub/repo2docker:2024.07.0-68.gdd097a2
221-
memory_limit: "3G"
222221
memory_request: "1G"
223222

224223
extraConfig:

0 commit comments

Comments
 (0)