Change patterned_text field type's template id to be not indexed (elastic#132051)

Turn off indexing and enable doc value skippers for patterned_text templateId field.

Author: martijnvg

x-pack/plugin/logsdb/src/main/java/org/elasticsearch/xpack/logsdb/patternedtext/PatternedTextFieldMapper.java

@@ -33,8 +33,6 @@
 import java.util.List;
 import java.util.Map;
 
-import static org.elasticsearch.index.IndexSettings.USE_DOC_VALUES_SKIPPER;
-
 /**
  * A {@link FieldMapper} that assigns every document the same value.
  */
@@ -62,25 +60,12 @@ public static class Builder extends FieldMapper.Builder {
         private final IndexSettings indexSettings;
         private final Parameter<Map<String, String>> meta = Parameter.metaParam();
         private final TextParams.Analyzers analyzers;
-        private final boolean enableDocValuesSkipper;
 
         public Builder(String name, MappingParserContext context) {
-            this(
-                name,
-                context.indexVersionCreated(),
-                context.getIndexSettings(),
-                context.getIndexAnalyzers(),
-                USE_DOC_VALUES_SKIPPER.get(context.getSettings())
-            );
+            this(name, context.indexVersionCreated(), context.getIndexSettings(), context.getIndexAnalyzers());
         }
 
-        public Builder(
-            String name,
-            IndexVersion indexCreatedVersion,
-            IndexSettings indexSettings,
-            IndexAnalyzers indexAnalyzers,
-            boolean enableDocValuesSkipper
-        ) {
+        public Builder(String name, IndexVersion indexCreatedVersion, IndexSettings indexSettings, IndexAnalyzers indexAnalyzers) {
             super(name);
             this.indexCreatedVersion = indexCreatedVersion;
             this.indexSettings = indexSettings;
@@ -90,7 +75,6 @@ public Builder(
                 m -> ((PatternedTextFieldMapper) m).positionIncrementGap,
                 indexCreatedVersion
             );
-            this.enableDocValuesSkipper = enableDocValuesSkipper;
         }
 
         @Override
@@ -120,8 +104,8 @@ public PatternedTextFieldMapper build(MapperBuilderContext context) {
                 patternedTextFieldType.templateIdFieldName(),
                 indexSettings.getMode(),
                 indexCreatedVersion,
-                enableDocValuesSkipper
-            ).build(context);
+                true
+            ).indexed(false).build(context);
             return new PatternedTextFieldMapper(leafName(), patternedTextFieldType, builderParams, this, templateIdMapper);
         }
     }
@@ -132,7 +116,6 @@ public PatternedTextFieldMapper build(MapperBuilderContext context) {
     private final IndexAnalyzers indexAnalyzers;
     private final IndexSettings indexSettings;
     private final NamedAnalyzer indexAnalyzer;
-    private final boolean enableDocValuesSkipper;
     private final int positionIncrementGap;
     private final FieldType fieldType;
     private final KeywordFieldMapper templateIdMapper;
@@ -152,7 +135,6 @@ private PatternedTextFieldMapper(
         this.indexAnalyzers = builder.analyzers.indexAnalyzers;
         this.indexAnalyzer = builder.analyzers.getIndexAnalyzer();
         this.indexSettings = builder.indexSettings;
-        this.enableDocValuesSkipper = builder.enableDocValuesSkipper;
         this.positionIncrementGap = builder.analyzers.positionIncrementGap.getValue();
         this.templateIdMapper = templateIdMapper;
     }
@@ -164,7 +146,7 @@ public Map<String, NamedAnalyzer> indexAnalyzers() {
 
     @Override
     public FieldMapper.Builder getMergeBuilder() {
-        return new Builder(leafName(), indexCreatedVersion, indexSettings, indexAnalyzers, enableDocValuesSkipper).init(this);
+        return new Builder(leafName(), indexCreatedVersion, indexSettings, indexAnalyzers).init(this);
     }
 
     @Override

x-pack/plugin/logsdb/src/test/java/org/elasticsearch/xpack/logsdb/patternedtext/PatternedTextFieldMapperTests.java

@@ -24,7 +24,6 @@
 import org.elasticsearch.common.Strings;
 import org.elasticsearch.common.settings.Settings;
 import org.elasticsearch.core.Tuple;
-import org.elasticsearch.index.IndexSettings;
 import org.elasticsearch.index.mapper.DateFieldMapper;
 import org.elasticsearch.index.mapper.DocumentMapper;
 import org.elasticsearch.index.mapper.KeywordFieldMapper;
@@ -131,10 +130,7 @@ protected void minimalStoreMapping(XContentBuilder b) throws IOException {
     }
 
     public void testDefaults() throws IOException {
-        boolean enabledDocValuesSkipper = randomBoolean();
-        var indexSettings = getIndexSettingsBuilder().put(IndexSettings.USE_DOC_VALUES_SKIPPER.getKey(), enabledDocValuesSkipper).build();
-
-        DocumentMapper mapper = createMapperService(indexSettings, fieldMapping(this::minimalMapping)).documentMapper();
+        DocumentMapper mapper = createMapperService(fieldMapping(this::minimalMapping)).documentMapper();
         assertEquals(Strings.toString(fieldMapping(this::minimalMapping)), mapper.mappingSource().toString());
 
         ParsedDocument doc = mapper.parse(source(b -> b.field("field", "1234")));
@@ -162,7 +158,7 @@ public void testDefaults() throws IOException {
             assertThat(fieldType.omitNorms(), equalTo(true));
             assertFalse(fieldType.tokenized());
             assertFalse(fieldType.stored());
-            assertThat(fieldType.indexOptions(), equalTo(enabledDocValuesSkipper ? IndexOptions.NONE : IndexOptions.DOCS));
+            assertThat(fieldType.indexOptions(), equalTo(IndexOptions.NONE));
             assertThat(fieldType.storeTermVectors(), equalTo(false));
             assertThat(fieldType.storeTermVectorOffsets(), equalTo(false));
             assertThat(fieldType.storeTermVectorPositions(), equalTo(false));