Skip to content

Commit 7467fc5

Browse files
authored
fix: logging-issues (#256)
1 parent bc68d2f commit 7467fc5

File tree

5 files changed

+4
-20
lines changed

5 files changed

+4
-20
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ RUN apt-get update && \
9292
patchelf \
9393
&& rm -rf /var/lib/apt/lists/*
9494

95-
RUN uv pip install scons && \
95+
RUN uv pip install --no-cache-dir scons~=4.9 && \
9696
uv sync --group compile && \
9797
uv pip list
9898

src/example_app/gunicorn.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,14 @@
66
import uvicorn.workers
77
from gunicorn import config, glogging
88

9-
from .logger import InterceptHandler, get_logger
9+
from .logger import InterceptHandler
1010
from .settings import settings
1111

1212

1313
class GunicornLogger(glogging.Logger):
1414
def __init__(self: GunicornLogger, cfg: config.Config) -> None:
1515
super().__init__(cfg)
1616

17-
get_logger()
1817
for name in ["gunicorn.error", "gunicorn.access"]:
1918
logging.getLogger(name).handlers = [InterceptHandler(depth=1)]
2019

src/example_app/logger.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
from __future__ import annotations
22

3-
import atexit
43
import inspect
54
import logging
6-
import sys
75

86
import loguru
97
from loguru import logger
@@ -36,17 +34,6 @@ def emit(self: InterceptHandler, record: logging.LogRecord) -> None:
3634

3735

3836
def get_logger() -> loguru.Logger:
39-
from .settings import settings
40-
41-
logger.remove()
42-
logger.add(
43-
sys.stderr, level=settings.loguru_level.upper(), enqueue=settings.loguru_enqueue
44-
)
45-
atexit.register(logger.complete)
46-
47-
logging.basicConfig(
48-
level=settings.loguru_level.upper(), handlers=[InterceptHandler()]
49-
)
5037
for name in ["uvicorn.access", "uvicorn.error"]:
5138
if name in logging.root.manager.loggerDict:
5239
_logger = logging.getLogger(name)

src/example_app/main.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,4 @@ async def ok() -> Ok:
2929
host=settings.host,
3030
port=settings.port,
3131
reload=True,
32-
log_config=None,
3332
)

src/example_app/settings.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,8 @@ class Settings(BaseSettings):
1616
port: int = 8000
1717
web_concurrency: int = 2 * multiprocessing.cpu_count() + 1
1818

19-
# logging
20-
loguru_level: str = "info"
21-
loguru_enqueue: bool = True
19+
# loguru
20+
loguru_level: str = "INFO"
2221

2322
model_config = SettingsConfigDict(env_file=".env")
2423

0 commit comments

Comments
 (0)