Skip to content

Commit a56f688

Browse files
authored
fix: dockerfile args (#166)
1 parent ac6c740 commit a56f688

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,9 @@ jobs:
106106
env:
107107
ENVIRONMENT: ci
108108

109-
- run: docker run --rm ${{ steps.build-ci.outputs.imageid }}
109+
- run: docker run --rm "${IMAGE_ID}"
110+
env:
111+
IMAGE_ID: ${{ steps.build-ci.outputs.imageid }}
110112

111113
- id: docker_metadata
112114
uses: docker/metadata-action@902fa8ec7d6ecbf8d84d538b9b233a880e428804 # v5

Dockerfile

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ RUN useradd --create-home --shell /bin/false --uid ${UID} ${USER}
1212
# set up environment
1313
ARG APP_HOME=/work/app
1414
ARG VIRTUAL_ENV=${APP_HOME}/.venv
15-
ENV PYTHONFAULTHANDLER=1 \
15+
ENV PATH=${VIRTUAL_ENV}/bin:${PATH} \
16+
PYTHONFAULTHANDLER=1 \
1617
PYTHONUNBUFFERED=1 \
17-
VIRTUAL_ENV=${VIRTUAL_ENV} \
18-
PATH=${VIRTUAL_ENV}/bin:${PATH}
18+
VIRTUAL_ENV=${VIRTUAL_ENV}
1919

2020
WORKDIR ${APP_HOME}
2121

@@ -40,12 +40,8 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
4040
curl=7.88.1-10+deb12u8 \
4141
&& rm -rf /var/lib/apt/lists/*
4242

43-
ARG PIP_DISABLE_PIP_VERSION_CHECK=1 \
44-
PIP_NO_CACHE_DIR=0 \
45-
PIP_NO_COMPILE=0 \
46-
PIP_NO_INPUT=1 \
47-
PYTHONDONTWRITEBYTECODE=1 \
48-
UV_NO_CACHE=1
43+
ARG PYTHONDONTWRITEBYTECODE=1
44+
ARG UV_NO_CACHE=1
4945

5046
# set up python
5147
COPY --from=ghcr.io/astral-sh/uv:latest@sha256:031ddbc79275e351a43cbb66f64d8cd314cc78c3878898f4ab4f147b092e8e2d /uv /uvx /bin/

0 commit comments

Comments
 (0)