eth/gasestimator: fix potential overflow (ethereum#32255)

gzeoneth · web-flow · commit 3b67602c4c5e · 2025-07-23T11:41:37.000+08:00
Improve binary search, preventing the potential overflow in certain L2 cases
diff --git a/eth/gasestimator/gasestimator.go b/eth/gasestimator/gasestimator.go
@@ -170,7 +170,7 @@ func Estimate(ctx context.Context, call *core.Message, opts *Options, gasCap uin
 				break
 			}
 		}
-		mid := (hi + lo) / 2
+		mid := lo + (hi-lo)/2
 		if mid > lo*2 {
 			// Most txs don't need much higher gas limit than their gas used, and most txs don't
 			// require near the full block limit of gas, so the selection of where to bisect the

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ func Estimate(ctx context.Context, call core.Message, opts Options, gasCap uin`
`170`	`170`	`break`
`171`	`171`	`}`
`172`	`172`	`}`
`173`		`- mid := (hi + lo) / 2`
	`173`	`+ mid := lo + (hi-lo)/2`
`174`	`174`	`if mid > lo*2 {`
`175`	`175`	`// Most txs don't need much higher gas limit than their gas used, and most txs don't`
`176`	`176`	`// require near the full block limit of gas, so the selection of where to bisect the`