Skip to content

Permission middleware check condition incorrect. #5880

@Dennies-Chang

Description

@Dennies-Chang

The condition Line 32 in src/Middleware/Permission.php is incorrect.

The code is:
if (!Admin::user() || !empty($args) || $this->shouldPassThrough($request)) {
return $next($request);
}

However if I used as sample code, the $args will be "not empty", and the condition will be always true,
and the permission check logic will never be used.

It should be corrected as:
if (!Admin::user() || empty($args) || $this->shouldPassThrough($request)) {
return $next($request);
}

The "!" prefixed for empty($args) should be removed, would you please fix it? Thanks.

Best Regards,
Dennies Chang.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions