test: ensure pending state is always sent

Author: z0al

test/bot.test.js

@@ -5,7 +5,16 @@ const { createRobot } = require('probot')
 // Ours
 const app = require('../index')
 const githubMock = require('./mocks/github')
-const payload = require('./payload')
+const events = require('./events')
+
+// Constants
+const baseStatus = {
+	sha: '123456789',
+	repo: 'test-commitlint-bot',
+	owner: 'ahmed-taj',
+	context: 'commitlint-bot',
+	target_url: 'http://npm.im/@commitlint/config-angular#problems'
+}
 
 describe('commitlint-bot', () => {
 	let robot
@@ -24,10 +33,18 @@ describe('commitlint-bot', () => {
 
 	describe('update status to pending', () => {
 		it('calls createStatus with "pending"', async () => {
+			const pending = {
+				...baseStatus,
+				state: 'pending',
+				description: 'Waiting for the status to be reported'
+			}
 			// Simulates delivery of a payload
-			await robot.receive(payload.opened)
-			// expect(github.repos.createStatus).toHaveBeenCalled()
-			expect(true).toBeTruthy()
+			// New PR
+			await robot.receive(events.opened)
+			expect(github.repos.createStatus).toHaveBeenCalledWith(pending)
+			// Updated PR
+			await robot.receive(events.synchronize)
+			expect(github.repos.createStatus).toHaveBeenCalledWith(pending)
 		})
 	})
 })

test/events/pull_request.opened.json

@@ -8,7 +8,7 @@
 				"login": "ahmed-taj"
 			},
 			"head": {
-				"sha": "5c1dc266b4aafa28ce6aa5cafd5b65b87febd5fc",
+				"sha": "123456789",
 				"user": {
 					"login": "ahmed-taj"
 				}

test/events/pull_request.synchronize.json

@@ -8,7 +8,7 @@
 				"login": "ahmed-taj"
 			},
 			"head": {
-				"sha": "f53aa23db7a778a93539e44069e03111b2dd033b",
+				"sha": "123456789",
 				"user": {
 					"login": "ahmed-taj"
 				}

test/mocks/github.js

@@ -2,10 +2,22 @@
 const expect = require('expect')
 
 // Mock necessary GitHub APIs here
-module.exports = () => {
+module.exports = data => {
+	const commits = data || [
+		{ commit: { message: 'fix: issue #1' } },
+		{ commit: { message: 'fix: issue #2' } },
+		{ commit: { message: 'fix: issue #3' } },
+		{ commit: { message: 'fix: issue #4' } }
+	]
 	return {
 		repos: {
 			createStatus: expect.createSpy()
+		},
+		pullRequests: {
+			getCommits: expect.createSpy().andReturn(Promise.resolve({ commits }))
+		},
+		paginate: (fn, callback) => {
+			callback(fn)
 		}
 	}
 }