Skip to content

Commit 65fedb3

Browse files
authored
Merge pull request #28 from z8dn/fix/qodana-issues
Address Qodana issues
2 parents ef95932 + e65621e commit 65fedb3

File tree

7 files changed

+4
-150
lines changed

7 files changed

+4
-150
lines changed

src/main/kotlin/com/z8dn/plugins/a2pt/AndroidViewNodeUtils.kt

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -80,17 +80,6 @@ object AndroidViewNodeUtils {
8080
return AndroidViewSettings.getInstance().showProjectFilesInModule
8181
}
8282

83-
/**
84-
* Checks if a PsiFile should be shown in the project-level files group.
85-
* Similar to showInProjectBuildScriptsGroup for build files.
86-
*
87-
* @return true if file should be shown in project-level group, false if in module
88-
*/
89-
fun showInProjectFilesGroup(): Boolean {
90-
// If showProjectFilesInModule is false, all project files go to project-level group
91-
return !showProjectFilesInModule()
92-
}
93-
9483
/**
9584
* Gets all project files from the entire project that match configured patterns.
9685
* Searches all module content roots in the project.

src/main/kotlin/com/z8dn/plugins/a2pt/AndroidViewSettings.kt

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,7 @@ import com.intellij.util.xmlb.XmlSerializerUtil
1313
data class ProjectFileGroup(
1414
var groupName: String = "",
1515
var patterns: MutableList<String> = mutableListOf()
16-
) {
17-
// No-arg constructor for XML serialization
18-
constructor() : this("", mutableListOf())
19-
}
16+
)
2017

2118
@State(
2219
name = "AndroidViewSettings",

src/main/kotlin/com/z8dn/plugins/a2pt/AndroidViewSettingsConfigurable.kt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -114,11 +114,7 @@ class AndroidViewSettingsConfigurable : SearchableConfigurable {
114114
}
115115

116116
val currentGroups = groupsTableModel?.getGroups() ?: emptyList()
117-
if (currentGroups != settings.projectFileGroups) {
118-
return true
119-
}
120-
121-
return false
117+
return currentGroups != settings.projectFileGroups
122118
}
123119

124120
override fun apply() {

src/main/kotlin/com/z8dn/plugins/a2pt/CustomFileNodeWithModule.kt

Lines changed: 0 additions & 103 deletions
This file was deleted.

src/main/kotlin/com/z8dn/plugins/a2pt/CustomNodeGrouping.kt

Lines changed: 0 additions & 25 deletions
This file was deleted.

src/main/kotlin/com/z8dn/plugins/a2pt/ProjectFileDisplayUtils.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ object ProjectFileDisplayUtils {
2424
* @param module The module containing the file
2525
* @return Display name with module prefix (Module/Project/Build)
2626
*/
27-
fun generateDisplayName(file: VirtualFile, module: Module): String? {
27+
fun generateDisplayName(file: VirtualFile, module: Module): String {
2828
// Get Gradle identity path and project path to determine the display name format
2929
val gradleIdentityPath = module.getGradleIdentityPath()
3030
val gradleProjectPath = module.getGradleProjectPath()?.toHolder()

src/main/resources/messages/AndroidViewBundle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ action.ShowProjectFilesInModuleAction.text=Display Project Files in Modules
44

55
# Settings
66
settings.displayName=Advanced Android Project View
7-
settings.showBuildDirectory=Show Build Directory
7+
settings.showBuildDirectory=Show build directory
88
settings.showBuildDirectory.tooltip=Show the build directory in Android modules
99
settings.customFileGroups.border=Custom File Groups
1010
settings.customFileGroups.help=Each group can contain multiple file patterns (e.g., *.md, LICENSE, README.md)

0 commit comments

Comments
 (0)