Skip to content

Commit ddbe178

Browse files
author
zTree
authored
Merge pull request #471 from afilippov1985/fix/inline-javascript
Add onclick handler only if it's not empty
2 parents 60796de + 11618d5 commit ddbe178

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

js/jquery.ztree.core.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1343,8 +1343,9 @@
13431343
}
13441344
html.push("<a id='", node.tId, consts.id.A, "' class='", consts.className.LEVEL, node.level,
13451345
nodeClasses.add ? ' ' + nodeClasses.add.join(' ') : '',
1346-
"' treeNode", consts.id.A, " onclick=\"", (node.click || ''),
1347-
"\" ", ((url != null && url.length > 0) ? "href='" + url + "'" : ""), " target='", view.makeNodeTarget(node), "' style='", fontStyle.join(''),
1346+
"' treeNode", consts.id.A,
1347+
node.click ? " onclick=\"" + node.click + "\"" : "",
1348+
((url != null && url.length > 0) ? " href='" + url + "'" : ""), " target='", view.makeNodeTarget(node), "' style='", fontStyle.join(''),
13481349
"'");
13491350
if (tools.apply(setting.view.showTitle, [setting.treeId, node], setting.view.showTitle) && title) {
13501351
html.push("title='", title.replace(/'/g, "&#39;").replace(/</g, '&lt;').replace(/>/g, '&gt;'), "'");
@@ -2015,4 +2016,4 @@
20152016
var zt = $.fn.zTree,
20162017
$$ = tools.$,
20172018
consts = zt.consts;
2018-
})(jQuery);
2019+
})(jQuery);

0 commit comments

Comments
 (0)