Merge pull request #782 from zackproser/improve-comparisons-again

Add generateStaticParams to comparison routes to fix 404 errors

Author: zackproser

src/app/comparisons/[tool1]/vs/[tool2]/page.tsx

@@ -0,0 +1,136 @@
+import { Suspense } from 'react'
+import { notFound } from 'next/navigation'
+import { Metadata } from 'next'
+import { getToolBySlug, getAllTools } from '@/actions/tool-actions'
+import ComparisonPageLayout from '@/components/ComparisonPageLayout'
+
+import { createMetadata } from '@/utils/createMetadata'
+import { ComparisonPageSkeleton } from '@/components/comparison-page-skeleton'
+
+interface PageProps {
+  params: Promise<{
+    tool1: string
+    tool2: string
+  }>
+}
+
+// Generate static params for all possible tool combinations
+export async function generateStaticParams() {
+  try {
+    const tools = await getAllTools()
+    const params = []
+    
+    // Generate all possible combinations of tools
+    for (let i = 0; i < tools.length; i++) {
+      for (let j = i + 1; j < tools.length; j++) {
+        const tool1 = tools[i]
+        const tool2 = tools[j]
+        
+        // Create slug from tool name
+        const createSlug = (name: string) => {
+          return name
+            .toLowerCase()
+            .replace(/[^a-z0-9\s-]/g, '') // Remove special characters except spaces and hyphens
+            .replace(/\s+/g, '-') // Replace spaces with hyphens
+            .replace(/-+/g, '-') // Replace multiple hyphens with single hyphen
+            .replace(/^-|-$/g, '') // Remove leading/trailing hyphens
+        }
+        
+        const tool1Slug = createSlug(tool1.name)
+        const tool2Slug = createSlug(tool2.name)
+        
+        // Add both combinations (tool1 vs tool2 and tool2 vs tool1)
+        params.push({
+          tool1: tool1Slug,
+          tool2: tool2Slug
+        })
+        params.push({
+          tool1: tool2Slug,
+          tool2: tool1Slug
+        })
+      }
+    }
+    
+    console.log(`Generated ${params.length} static params for comparison routes`)
+    return params
+  } catch (error) {
+    console.error('Error generating static params for comparisons:', error)
+    return []
+  }
+}
+
+// Generate metadata for SEO
+export async function generateMetadata({ params }: PageProps): Promise<Metadata> {
+  const { tool1: tool1Slug, tool2: tool2Slug } = await params
+  
+  try {
+    const [tool1, tool2] = await Promise.all([
+      getToolBySlug(tool1Slug),
+      getToolBySlug(tool2Slug)
+    ])
+
+    if (!tool1 || !tool2) {
+      return createMetadata({
+        title: "Comparison Not Found",
+        description: "The requested tool comparison could not be found."
+      })
+    }
+
+    return createMetadata({
+      title: `${tool1.name} vs ${tool2.name}`,
+      description: `Compare ${tool1.name} and ${tool2.name} - features, pricing, pros and cons. Find the best tool for your development needs.`,
+      slug: `${tool1Slug}-vs-${tool2Slug}`
+    })
+  } catch (error) {
+    console.error('Error generating metadata:', error)
+    return createMetadata({
+      title: "Comparison Error",
+      description: "Error loading comparison data."
+    })
+  }
+}
+
+async function ComparisonContent({ tool1Slug, tool2Slug }: { tool1Slug: string, tool2Slug: string }) {
+  try {
+    const [tool1, tool2] = await Promise.all([
+      getToolBySlug(tool1Slug),
+      getToolBySlug(tool2Slug)
+    ])
+    
+    if (!tool1 || !tool2) {
+      notFound()
+    }
+    
+    // Generate simple comparison prose
+    const proseParagraphs = [
+      `Choosing between ${tool1.name} and ${tool2.name} is a common decision for developers. Both tools have their unique strengths and serve different use cases in the development workflow.`,
+      `${tool1.name} ${tool1.description ? `is ${tool1.description.toLowerCase()}` : 'offers a comprehensive set of features'}, making it suitable for teams that prioritize reliability and ease of use.`,
+      `${tool2.name} ${tool2.description ? `focuses on ${tool2.description.toLowerCase()}` : 'provides powerful capabilities'}, which appeals to developers who value performance and flexibility.`,
+      `When making your decision, consider factors like your budget, team size, integration requirements, and long-term scalability needs. This comparison will help you understand which tool aligns better with your specific requirements.`
+    ]
+    
+    return (
+      <ComparisonPageLayout 
+        tool1={tool1} 
+        tool2={tool2} 
+        proseParagraphs={proseParagraphs}
+      />
+    )
+  } catch (error) {
+    console.error('Error loading comparison:', error)
+    throw error
+  }
+}
+
+export default async function ComparisonPage({ params }: PageProps) {
+  const { tool1: tool1Slug, tool2: tool2Slug } = await params
+  
+  return (
+    <Suspense fallback={<ComparisonPageSkeleton />}>
+      <ComparisonContent tool1Slug={tool1Slug} tool2Slug={tool2Slug} />
+    </Suspense>
+  )
+}
+
+// Enable ISR with 1 hour revalidation
+export const revalidate = 3600