Skip to content

Commit 0095d5f

Browse files
authored
Merge pull request quarkusio#36322 from yrodiere/build-prop-no-warn
Do not warn on static init about clearly build-related properties being set in environment variables
2 parents 291e0f2 + 0936ebb commit 0095d5f

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

core/deployment/src/main/java/io/quarkus/deployment/pkg/steps/NativeImageBuildStep.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import io.quarkus.deployment.annotations.BuildProducer;
2828
import io.quarkus.deployment.annotations.BuildStep;
2929
import io.quarkus.deployment.builditem.NativeImageFeatureBuildItem;
30+
import io.quarkus.deployment.builditem.SuppressNonRuntimeConfigChangedWarningBuildItem;
3031
import io.quarkus.deployment.builditem.nativeimage.ExcludeConfigBuildItem;
3132
import io.quarkus.deployment.builditem.nativeimage.JPMSExportBuildItem;
3233
import io.quarkus.deployment.builditem.nativeimage.NativeImageAllowIncompleteClasspathAggregateBuildItem;
@@ -362,6 +363,22 @@ public NativeImageRunnerBuildItem dummyNativeImageBuildRunner(NativeConfig nativ
362363
return new NativeImageRunnerBuildItem(new NoopNativeImageBuildRunner(explicitContainerBuild));
363364
}
364365

366+
@BuildStep
367+
public void ignoreBuildPropertyChanges(BuildProducer<SuppressNonRuntimeConfigChangedWarningBuildItem> producer) {
368+
// Don't produce warnings on static init for properties that are overridden through environment variables
369+
// if they are clearly only relevant when building.
370+
for (String propertyKey : new String[] {
371+
"quarkus.native.container-build",
372+
"quarkus.native.remote-container-build",
373+
"quarkus.native.builder-image.image",
374+
"quarkus.native.builder-image.pull",
375+
"quarkus.native.container-runtime",
376+
"quarkus.native.container-runtime-options"
377+
}) {
378+
producer.produce(new SuppressNonRuntimeConfigChangedWarningBuildItem(propertyKey));
379+
}
380+
}
381+
365382
private void copyJarSourcesToLib(OutputTargetBuildItem outputTargetBuildItem,
366383
CurateOutcomeBuildItem curateOutcomeBuildItem) {
367384
Path targetDirectory = outputTargetBuildItem.getOutputDirectory()

0 commit comments

Comments
 (0)