Skip to content

Commit 3806626

Browse files
committed
quarkusio#50126 HQL console: correct allow-hql config on hot reload and enter key to run query
1 parent f16dd61 commit 3806626

File tree

1 file changed

+17
-19
lines changed

1 file changed

+17
-19
lines changed

extensions/hibernate-orm/deployment/src/main/resources/dev-ui/hibernate-orm-hql-console.js

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import {css, html, QwcHotReloadElement} from 'qwc-hot-reload-element';
2-
import {RouterController} from 'router-controller';
32
import {JsonRpc} from 'jsonrpc';
43
import {StorageController} from 'storage-controller';
54
import '@vaadin/icon';
@@ -10,15 +9,13 @@ import '@vaadin/text-area';
109
import '@vaadin/progress-bar';
1110
import '@vaadin/tabs';
1211
import '@vaadin/tabsheet';
13-
import {notifier} from 'notifier';
1412
import {assistantState} from 'assistant-state';
1513
import 'qui-assistant-warning';
1614
import {observeState} from 'lit-element-state';
1715

1816
export class HibernateOrmHqlConsoleComponent extends observeState(QwcHotReloadElement) {
1917
jsonRpc = new JsonRpc(this);
2018
configJsonRpc = new JsonRpc("devui-configuration");
21-
routerController = new RouterController(this);
2219
storageControl = new StorageController(this);
2320

2421
static styles = css`
@@ -281,28 +278,29 @@ export class HibernateOrmHqlConsoleComponent extends observeState(QwcHotReloadEl
281278

282279
connectedCallback() {
283280
super.connectedCallback();
284-
285-
const page = this.routerController.getCurrentPage();
286-
if (page && page.metadata) {
287-
this._allowHql = (page.metadata.allowHql === "true");
288-
} else {
289-
this._allowHql = false;
290-
}
291-
292281
this.hotReload();
293282
}
294283

295284
hotReload() {
296285
this._loading = true;
297-
this.jsonRpc.getInfo().then(response => {
298-
this._persistenceUnits = response.result.persistenceUnits;
299-
this._selectPersistenceUnit(this._persistenceUnits[0]);
300-
this._loading = false;
286+
const configPromise = this.configJsonRpc.getAllValues();
287+
const infoPromise = this.jsonRpc.getInfo();
288+
Promise.all([configPromise, infoPromise]).then(responses => {
289+
const configResponse = responses[0];
290+
const infoResponse = responses[1];
291+
if (configResponse && configResponse.result) {
292+
const allowHqlConfig = configResponse.result['quarkus.hibernate-orm.dev-ui.allow-hql'];
293+
this._allowHql = allowHqlConfig && allowHqlConfig === 'true';
294+
}
295+
if (infoResponse && infoResponse.result) {
296+
this._persistenceUnits = infoResponse.result.persistenceUnits;
297+
this._selectPersistenceUnit(this._persistenceUnits[0]);
298+
}
301299
}).catch(error => {
302-
console.error("Failed to fetch persistence units:", error);
303-
this._persistenceUnits = [];
300+
console.error("Failed to fetch configuration or persistence units:", error);
301+
this._addErrorMessage("Failed to fetch configuration or persistence units: " + error);
302+
}).finally(() => {
304303
this._loading = false;
305-
notifier.showErrorMessage("Failed to fetch persistence units: " + error, "bottom-start", 30);
306304
});
307305
}
308306

@@ -735,7 +733,7 @@ export class HibernateOrmHqlConsoleComponent extends observeState(QwcHotReloadEl
735733
}
736734

737735
_handleKeyDown(event) {
738-
if (event.key === 'Enter' && (event.ctrlKey || event.metaKey)) {
736+
if (event.key === 'Enter') {
739737
event.preventDefault();
740738
this._sendQuery();
741739
}

0 commit comments

Comments
 (0)