Merge pull request quarkusio#50234 from gsmet/avoid-toexternalform

Reduce allocations due to ClassLoader#defineClassSourceLocation

Author: gsmet

independent-projects/bootstrap/runner/src/main/java/io/quarkus/bootstrap/runner/JarResource.java

@@ -1,11 +1,16 @@
 package io.quarkus.bootstrap.runner;
 
+import java.io.File;
+import java.io.FileInputStream;
+import java.io.FileNotFoundException;
 import java.io.IOException;
 import java.io.InputStream;
 import java.net.MalformedURLException;
 import java.net.URI;
 import java.net.URISyntaxException;
 import java.net.URL;
+import java.net.URLConnection;
+import java.net.URLStreamHandler;
 import java.nio.file.Path;
 import java.security.CodeSource;
 import java.security.ProtectionDomain;
@@ -44,7 +49,7 @@ public void init() {
                 path = '/' + path;
             }
             URI uri = new URI("file", null, path, null);
-            url = uri.toURL();
+            url = new URL((URL) null, uri.toString(), new JarUrlStreamHandler(uri));
         } catch (URISyntaxException | MalformedURLException e) {
             throw new RuntimeException("Unable to create protection domain for " + jarPath, e);
         }
@@ -201,4 +206,73 @@ public boolean equals(Object o) {
     public int hashCode() {
         return Objects.hashCode(jarPath);
     }
+
+    /**
+     * This URLStreamHandler is designed to handle only one jar, which is the one passed in the constructor.
+     * The goal here is to cache the external form of the URL.
+     * <p>
+     * Do not use this class outside of this extremely specific purpose.
+     */
+    private static class JarUrlStreamHandler extends URLStreamHandler {
+
+        private final String externalForm;
+
+        private JarUrlStreamHandler(URI uri) {
+            this.externalForm = "file:".concat(uri.getRawPath());
+            // while it would be more optimized to store the URI here for when we open connections
+            // opening a connection for ProtectionDomains is actually extremely rare
+            // and never done in production at runtime so we favored reducing memory allocations for the common case
+        }
+
+        @Override
+        protected URLConnection openConnection(URL u) throws IOException {
+            return new JarURLConnection(u);
+        }
+
+        @Override
+        protected String toExternalForm(URL u) {
+            return externalForm;
+        }
+    }
+
+    private static class JarURLConnection extends URLConnection {
+
+        private final File file;
+
+        private JarURLConnection(URL url) throws IOException {
+            super(url);
+            try {
+                this.file = new File(url.toURI());
+            } catch (URISyntaxException e) {
+                throw new IOException(e);
+            }
+        }
+
+        @Override
+        public void connect() throws IOException {
+            if (!file.exists()) {
+                throw new FileNotFoundException(file.getAbsolutePath());
+            }
+        }
+
+        @Override
+        public InputStream getInputStream() throws IOException {
+            return new FileInputStream(file);
+        }
+
+        @Override
+        public int getContentLength() {
+            return (int) file.length();
+        }
+
+        @Override
+        public long getContentLengthLong() {
+            return file.length();
+        }
+
+        @Override
+        public String getContentType() {
+            return "application/java-archive";
+        }
+    }
 }

integration-tests/maven/src/test/resources-filtered/projects/classic/src/main/java/org/acme/ProtectionDomain.java

@@ -6,7 +6,10 @@
 import jakarta.ws.rs.Path;
 import java.io.IOException;
 import java.io.InputStream;
+import java.io.PrintWriter;
+import java.io.StringWriter;
 import java.net.URL;
+import java.util.Arrays;
 import java.util.jar.JarInputStream;
 import java.util.jar.Manifest;
 import java.nio.charset.StandardCharsets;
@@ -46,8 +49,9 @@ private String runAssertions(Supplier<String>... assertions) {
 
     private String assertReadManifestFromJar() {
         final String testType = "manifest-from-jar";
+        URL location = null;
         try {
-            URL location = org.apache.commons.io.Charsets.class.getProtectionDomain().getCodeSource().getLocation();
+            location = org.apache.commons.io.Charsets.class.getProtectionDomain().getCodeSource().getLocation();
             if (location == null) {
                 return errorResult(testType, "location should not be null");
             }
@@ -66,12 +70,19 @@ private String assertReadManifestFromJar() {
             }
             return SUCCESS;
         } catch (Exception e) {
-            e.printStackTrace();
-            return errorResult(testType, "exception during resolution of resource");
+            return errorResult(testType, "Exception during resolution of resource (" + location + "): " + e + "\n" + getStackTraceAsString(e));
         }
     }
 
     private String errorResult(String testType, String message) {
         return testType + " / " + message;
     }
+
+    private static String getStackTraceAsString(Throwable t) {
+        StringWriter sw = new StringWriter();
+        try (PrintWriter pw = new PrintWriter(sw)) {
+            t.printStackTrace(pw);
+        }
+        return sw.toString();
+    }
 }

integration-tests/maven/src/test/resources-filtered/projects/rr-with-json-logging/src/main/java/org/acme/ProtectionDomain.java

@@ -6,6 +6,8 @@
 import jakarta.ws.rs.Path;
 import java.io.IOException;
 import java.io.InputStream;
+import java.io.PrintWriter;
+import java.io.StringWriter;
 import java.net.URL;
 import java.util.jar.JarInputStream;
 import java.util.jar.Manifest;
@@ -46,8 +48,9 @@ private String runAssertions(Supplier<String>... assertions) {
 
     private String assertReadManifestFromJar() {
         final String testType = "manifest-from-jar";
+        URL location = null;
         try {
-            URL location = org.apache.commons.io.Charsets.class.getProtectionDomain().getCodeSource().getLocation();
+            location = org.apache.commons.io.Charsets.class.getProtectionDomain().getCodeSource().getLocation();
             if (location == null) {
                 return errorResult(testType, "location should not be null");
             }
@@ -66,12 +69,19 @@ private String assertReadManifestFromJar() {
             }
             return SUCCESS;
         } catch (Exception e) {
-            e.printStackTrace();
-            return errorResult(testType, "exception during resolution of resource");
+            return errorResult(testType, "Exception during resolution of resource (" + location + "): " + e + "\n" + getStackTraceAsString(e));
         }
     }
 
     private String errorResult(String testType, String message) {
         return testType + " / " + message;
     }
+
+    private static String getStackTraceAsString(Throwable t) {
+        StringWriter sw = new StringWriter();
+        try (PrintWriter pw = new PrintWriter(sw)) {
+            t.printStackTrace(pw);
+        }
+        return sw.toString();
+    }
 }