Skip to content

Commit 61de472

Browse files
authored
Merge pull request quarkusio#36035 from phillip-kruger/fix-info-git
Fix Dev UI Info where Full Git details
2 parents 26d7a56 + f8affcd commit 61de472

File tree

1 file changed

+41
-13
lines changed
  • extensions/info/deployment/src/main/resources/dev-ui

1 file changed

+41
-13
lines changed

extensions/info/deployment/src/main/resources/dev-ui/qwc-info.js

Lines changed: 41 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { LitElement, html, css} from 'lit';
2+
import {unsafeHTML} from 'lit/directives/unsafe-html.js';
23
import { columnBodyRenderer } from '@vaadin/grid/lit.js';
34
import { infoUrl } from 'build-time-data';
45
import '@vaadin/progress-bar';
@@ -22,13 +23,20 @@ export class QwcInfo extends LitElement {
2223
}
2324
.cardContent {
2425
display: flex;
25-
align-items: center;
2626
padding: 10px;
2727
gap: 10px;
28+
height: 100%;
2829
}
2930
vaadin-icon {
3031
font-size: xx-large;
3132
}
33+
.table {
34+
height: fit-content;
35+
}
36+
.row-header {
37+
color: var(--lumo-contrast-50pct);
38+
vertical-align: top;
39+
}
3240
`;
3341

3442
static properties = {
@@ -58,8 +66,8 @@ export class QwcInfo extends LitElement {
5866
return html`
5967
${this._renderOsInfo(this._info)}
6068
${this._renderJavaInfo(this._info)}
61-
${this._renderGitInfo(this._info)}
6269
${this._renderBuildInfo(this._info)}
70+
${this._renderGitInfo(this._info)}
6371
`;
6472
}else{
6573
return html`
@@ -78,9 +86,9 @@ export class QwcInfo extends LitElement {
7886
<div class="cardContent" slot="content">
7987
${this._renderOsIcon(os.name)}
8088
<table class="table">
81-
<tr><td>Name</td><td>${os.name}</td></tr>
82-
<tr><td>Version</td><td>${os.version}</td></tr>
83-
<tr><td>Arch</td><td>${os.arch}</td></tr>
89+
<tr><td class="row-header">Name</td><td>${os.name}</td></tr>
90+
<tr><td class="row-header">Version</td><td>${os.version}</td></tr>
91+
<tr><td class="row-header">Arch</td><td>${os.arch}</td></tr>
8492
</table>
8593
</div>
8694
</qui-card>`;
@@ -94,7 +102,7 @@ export class QwcInfo extends LitElement {
94102
<div class="cardContent" slot="content">
95103
<vaadin-icon icon="font-awesome-brands:java"></vaadin-icon>
96104
<table class="table">
97-
<tr><td>Version</td><td>${java.version}</td></tr>
105+
<tr><td class="row-header">Version</td><td>${java.version}</td></tr>
98106
</table>
99107
</div>
100108
</qui-card>`;
@@ -121,25 +129,45 @@ export class QwcInfo extends LitElement {
121129
<div class="cardContent" slot="content">
122130
<vaadin-icon icon="font-awesome-brands:git"></vaadin-icon>
123131
<table class="table">
124-
<tr><td>Branch</td><td>${git.branch}</td></tr>
125-
<tr><td>Commit</td><td>${git.commit.id}</td></tr>
126-
<tr><td>Time</td><td>${git.commit.time}</td></tr>
132+
<tr><td class="row-header">Branch</td><td>${git.branch}</td></tr>
133+
<tr><td class="row-header">Commit Id </td><td>${this._renderCommitId(git)}</td></tr>
134+
<tr><td class="row-header">Commit Time</td><td>${git.commit.time}</td></tr>
135+
${this._renderOptionalData(git)}
127136
</table>
128137
</div>
129138
</qui-card>`;
130139
}
131140
}
132141

142+
_renderCommitId(git){
143+
if(typeof git.commit.id === "string"){
144+
return html`${git.commit.id}`;
145+
}else {
146+
return html`${git.commit.id.full}`;
147+
}
148+
}
149+
150+
_renderOptionalData(git){
151+
if(typeof git.commit.id !== "string"){
152+
return html`<tr><td class="row-header">Commit User</td><td>${git.commit.user.name} &lt;${git.commit.user.email}&gt;</td></tr>
153+
<tr><td class="row-header">Commit Message</td><td>${unsafeHTML(this._replaceNewLine(git.commit.id.message.full))}</td></tr>`
154+
}
155+
}
156+
157+
_replaceNewLine(line){
158+
return line.replace(new RegExp('\r?\n','g'), '<br />');
159+
}
160+
133161
_renderBuildInfo(info){
134162
if(info.build){
135163
let build = info.build;
136164
return html`<qui-card title="Build">
137165
<div class="cardContent" slot="content">
138166
<table class="table">
139-
<tr><td>Group</td><td>${build.group}</td></tr>
140-
<tr><td>Artifact</td><td>${build.artifact}</td></tr>
141-
<tr><td>Version</td><td>${build.version}</td></tr>
142-
<tr><td>Time</td><td>${build.time}</td></tr>
167+
<tr><td class="row-header">Group</td><td>${build.group}</td></tr>
168+
<tr><td class="row-header">Artifact</td><td>${build.artifact}</td></tr>
169+
<tr><td class="row-header">Version</td><td>${build.version}</td></tr>
170+
<tr><td class="row-header">Time</td><td>${build.time}</td></tr>
143171
</table>
144172
</div>
145173
</qui-card>`;

0 commit comments

Comments
 (0)