Test no entity / no datasource cases with Hibernate with Panache

Author: yrodiere

extensions/hibernate-reactive/deployment/src/test/java/io/quarkus/hibernate/reactive/config/NoDatasourceTest.java

@@ -2,13 +2,13 @@
 
 import static org.assertj.core.api.Assertions.assertThat;
 
-import io.quarkus.arc.Arc;
-import io.quarkus.arc.InjectableInstance;
 import jakarta.inject.Inject;
+
 import org.hibernate.reactive.mutiny.Mutiny;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
 
+import io.quarkus.arc.InjectableInstance;
 import io.quarkus.test.QuarkusUnitTest;
 
 public class NoDatasourceTest {

extensions/panache/hibernate-orm-panache/deployment/src/test/java/io/quarkus/hibernate/orm/panache/deployment/test/NoConfigTest.java renamed to extensions/panache/hibernate-orm-panache/deployment/src/test/java/io/quarkus/hibernate/orm/panache/deployment/test/config/NoConfigTest.java

@@ -1,4 +1,4 @@
-package io.quarkus.hibernate.orm.panache.deployment.test;
+package io.quarkus.hibernate.orm.panache.deployment.test.config;
 
 import org.jboss.shrinkwrap.api.ShrinkWrap;
 import org.jboss.shrinkwrap.api.spec.JavaArchive;

extensions/panache/hibernate-orm-panache/deployment/src/test/java/io/quarkus/hibernate/orm/panache/deployment/test/config/NoDatasourceTest.java

@@ -0,0 +1,36 @@
+package io.quarkus.hibernate.orm.panache.deployment.test.config;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.assertj.core.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.quarkus.hibernate.orm.panache.deployment.test.MyEntity;
+import io.quarkus.test.QuarkusUnitTest;
+
+public class NoDatasourceTest {
+
+    @RegisterExtension
+    static QuarkusUnitTest runner = new QuarkusUnitTest()
+            .withApplicationRoot((jar) -> jar
+                    .addClass(MyEntity.class))
+            // Ideally we would not add quarkus-jdbc-h2 to the classpath and there _really_ wouldn't be a datasource,
+            // but that's inconvenient given our testing setup,
+            // so we'll just disable the implicit datasource.
+            .overrideConfigKey("quarkus.datasource.jdbc", "false")
+            .assertException(t -> assertThat(t)
+                    .hasMessageContainingAll(
+                            "Persistence unit '<default>' defines entities [" + MyEntity.class.getName()
+                                    + "], but its datasource '<default>' cannot be found",
+                            "Datasource '<default>' is not configured.",
+                            "To solve this, configure datasource '<default>'",
+                            "Refer to https://quarkus.io/guides/datasource for guidance.",
+                            "Alternatively, disable Hibernate ORM by setting 'quarkus.hibernate-orm.enabled=false', and the entities will be ignored"));
+
+    @Test
+    public void test() {
+        Assertions.fail("Startup should have failed");
+    }
+
+}

extensions/panache/hibernate-orm-panache/deployment/src/test/java/io/quarkus/hibernate/orm/panache/deployment/test/config/NoEntitiesNoDatasourceTest.java

@@ -0,0 +1,33 @@
+package io.quarkus.hibernate.orm.panache.deployment.test.config;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import jakarta.transaction.Transactional;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.quarkus.hibernate.orm.panache.Panache;
+import io.quarkus.test.QuarkusUnitTest;
+
+public class NoEntitiesNoDatasourceTest {
+
+    @RegisterExtension
+    static QuarkusUnitTest runner = new QuarkusUnitTest()
+            .withEmptyApplication()
+            // Ideally we would not add quarkus-jdbc-h2 to the classpath and there _really_ wouldn't be a datasource,
+            // but that's inconvenient given our testing setup,
+            // so we'll just disable the implicit datasource.
+            .overrideConfigKey("quarkus.datasource.jdbc", "false");
+
+    // Test for https://github.com/quarkusio/quarkus/issues/50247
+    // When having no entities, no configuration, and no datasource,
+    // we should still be able to start the application.
+    @Test
+    @Transactional
+    public void test() {
+        // But Hibernate ORM should be disabled, so its beans should not be there.
+        assertThat(Panache.getSession()).isNull();
+    }
+
+}

extensions/panache/hibernate-orm-panache/deployment/src/test/java/io/quarkus/hibernate/orm/panache/deployment/test/config/NoEntitiesTest.java

@@ -0,0 +1,31 @@
+package io.quarkus.hibernate.orm.panache.deployment.test.config;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import jakarta.transaction.Transactional;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.quarkus.hibernate.orm.panache.Panache;
+import io.quarkus.test.QuarkusUnitTest;
+
+/**
+ * Test that a persistence unit without any entities does get started,
+ * and can be used, be it only for native queries,
+ * as long as a datasource is present.
+ */
+public class NoEntitiesTest {
+
+    @RegisterExtension
+    static QuarkusUnitTest runner = new QuarkusUnitTest()
+            .withEmptyApplication();
+
+    @Test
+    @Transactional
+    public void testSessionNativeQuery() {
+        assertThat(Panache.getSession().createNativeQuery("select 1", Long.class).getResultList())
+                .containsExactly(1L);
+    }
+
+}

extensions/panache/hibernate-reactive-panache/deployment/src/test/java/io/quarkus/hibernate/reactive/panache/test/NoConfigTest.java renamed to extensions/panache/hibernate-reactive-panache/deployment/src/test/java/io/quarkus/hibernate/reactive/panache/test/config/NoConfigTest.java

@@ -1,4 +1,4 @@
-package io.quarkus.hibernate.reactive.panache.test;
+package io.quarkus.hibernate.reactive.panache.test.config;
 
 import org.jboss.shrinkwrap.api.ShrinkWrap;
 import org.jboss.shrinkwrap.api.spec.JavaArchive;

extensions/panache/hibernate-reactive-panache/deployment/src/test/java/io/quarkus/hibernate/reactive/panache/test/config/NoDatasourceTest.java

@@ -0,0 +1,36 @@
+package io.quarkus.hibernate.reactive.panache.test.config;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import jakarta.inject.Inject;
+
+import org.hibernate.reactive.mutiny.Mutiny;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.quarkus.arc.InjectableInstance;
+import io.quarkus.hibernate.reactive.panache.test.MyEntity;
+import io.quarkus.test.QuarkusUnitTest;
+
+public class NoDatasourceTest {
+
+    @RegisterExtension
+    static QuarkusUnitTest runner = new QuarkusUnitTest()
+            .withApplicationRoot((jar) -> jar
+                    .addClass(MyEntity.class))
+            // Ideally we would not add quarkus-reactive-pg-client to the classpath and there _really_ wouldn't be a datasource,
+            // but that's inconvenient given our testing setup,
+            // so we'll just disable the implicit datasource.
+            .overrideConfigKey("quarkus.datasource.reactive", "false");
+
+    @Inject
+    InjectableInstance<Mutiny.SessionFactory> sessionFactory;
+
+    @Test
+    public void test() {
+        // Unlike Hibernate ORM, Hibernate Reactive will silently disable itself if the default datasource is missing, even if there are entities.
+        // We may want to revisit that someday, but it's not easy to do without deeper interaction between the Hibernate ORM and Reactive extensions.
+        assertThat(sessionFactory.isUnsatisfied()).isTrue();
+    }
+
+}

extensions/panache/hibernate-reactive-panache/deployment/src/test/java/io/quarkus/hibernate/reactive/panache/test/config/NoEntitiesNoDatasourceTest.java

@@ -0,0 +1,32 @@
+package io.quarkus.hibernate.reactive.panache.test.config;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.quarkus.hibernate.reactive.panache.Panache;
+import io.quarkus.test.QuarkusUnitTest;
+import io.quarkus.test.vertx.RunOnVertxContext;
+
+public class NoEntitiesNoDatasourceTest {
+
+    @RegisterExtension
+    static QuarkusUnitTest runner = new QuarkusUnitTest()
+            .withEmptyApplication()
+            // Ideally we would not add quarkus-reactive-pg-client to the classpath and there _really_ wouldn't be a datasource,
+            // but that's inconvenient given our testing setup,
+            // so we'll just disable the implicit datasource.
+            .overrideConfigKey("quarkus.datasource.reactive", "false");
+
+    // When having no entities, no configuration, and no datasource,
+    // we should still be able to start the application.
+    @Test
+    @RunOnVertxContext
+    public void test() {
+        // ... but any attempt to use Panache at runtime should fail.
+        assertThatThrownBy(() -> Panache.getSession())
+                .hasMessage("Mutiny.SessionFactory bean not found");
+    }
+
+}

extensions/panache/hibernate-reactive-panache/deployment/src/test/java/io/quarkus/hibernate/reactive/panache/test/config/NoEntitiesTest.java

@@ -0,0 +1,32 @@
+package io.quarkus.hibernate.reactive.panache.test.config;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.quarkus.hibernate.reactive.panache.Panache;
+import io.quarkus.test.QuarkusUnitTest;
+import io.quarkus.test.vertx.RunOnVertxContext;
+import io.quarkus.test.vertx.UniAsserter;
+
+/**
+ * Test that a persistence unit without any entities does get started,
+ * and can be used, be it only for native queries,
+ * as long as a datasource is present.
+ */
+public class NoEntitiesTest {
+
+    @RegisterExtension
+    static QuarkusUnitTest runner = new QuarkusUnitTest()
+            .withEmptyApplication();
+
+    @Test
+    @RunOnVertxContext
+    public void testSessionNativeQuery(UniAsserter asserter) {
+        asserter.assertThat(() -> Panache.withTransaction(
+                () -> Panache.getSession().chain(session -> session.createNativeQuery("select 1", Long.class).getResultList())),
+                result -> assertThat(result).containsExactly(1L));
+    }
+
+}