Rework Hibernate tests around "no datasource" cases

The existing "NoConfigNoEntitiesTest" do not test that, they are strictly
equivalent to ConfigNoEntitiesDefaultPUDatasourceUrlMissingDynamicInjectionTest,
so they can be safely removed.

Testing there is no datasource requires that the Datasource extensions
not produce an implicit datasource, which would require that we don't
add a driver/client to the classpath. Since that's not practical, we'll
explicitly disable the implicit datasource instead.

Author: yrodiere

extensions/hibernate-orm/deployment/src/test/java/io/quarkus/hibernate/orm/config/NoConfigNoEntitiesTest.java

@@ -0,0 +1,33 @@
+package io.quarkus.hibernate.orm.config;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import org.assertj.core.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.quarkus.test.QuarkusUnitTest;
+
+public class NoDatasourceTest {
+
+    @RegisterExtension
+    static QuarkusUnitTest runner = new QuarkusUnitTest()
+            .withApplicationRoot((jar) -> jar
+                    .addClass(MyEntity.class))
+            // Ideally we would not add quarkus-jdbc-h2 to the classpath and there _really_ wouldn't be a datasource,
+            // but that's inconvenient given our testing setup,
+            // so we'll just disable the implicit datasource.
+            .overrideConfigKey("quarkus.datasource.jdbc", "false")
+            .assertException(t -> assertThat(t)
+                    .hasMessageContainingAll(
+                            "Unable to find datasource '<default>' for persistence unit '<default>'",
+                            "Datasource '<default>' is not configured.",
+                            "To solve this, configure datasource '<default>'",
+                            "Refer to https://quarkus.io/guides/datasource for guidance."));
+
+    @Test
+    public void test() {
+        Assertions.fail("Startup should have failed");
+    }
+
+}

extensions/hibernate-orm/deployment/src/test/java/io/quarkus/hibernate/orm/config/NoDatasourceTest.java

@@ -0,0 +1,38 @@
+package io.quarkus.hibernate.orm.config;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import jakarta.enterprise.context.control.ActivateRequestContext;
+import jakarta.inject.Inject;
+
+import org.hibernate.Session;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.quarkus.arc.InjectableInstance;
+import io.quarkus.test.QuarkusUnitTest;
+
+public class NoEntitiesNoDatasourceTest {
+
+    @RegisterExtension
+    static QuarkusUnitTest runner = new QuarkusUnitTest()
+            .withEmptyApplication()
+            // Ideally we would not add quarkus-jdbc-h2 to the classpath and there _really_ wouldn't be a datasource,
+            // but that's inconvenient given our testing setup,
+            // so we'll just disable the implicit datasource.
+            .overrideConfigKey("quarkus.datasource.jdbc", "false");
+
+    @Inject
+    InjectableInstance<Session> session;
+
+    // When having no entities, no configuration, and no datasource,
+    // as long as the Hibernate ORM beans are not injected anywhere,
+    // we should still be able to start the application.
+    @Test
+    @ActivateRequestContext
+    public void test() {
+        // But Hibernate ORM should be disabled, so its beans should not be there.
+        assertThat(session.isUnsatisfied()).isTrue();
+    }
+
+}

extensions/hibernate-orm/deployment/src/test/java/io/quarkus/hibernate/orm/config/NoEntitiesNoDatasourceTest.java

@@ -15,7 +15,8 @@
 
 /**
  * Test that a persistence unit without any entities does get started,
- * and can be used, be it only for native queries.
+ * and can be used, be it only for native queries,
+ * as long as a datasource is present.
  */
 public class NoEntitiesTest {
 

extensions/hibernate-orm/deployment/src/test/java/io/quarkus/hibernate/orm/config/NoEntitiesTest.java

@@ -0,0 +1,35 @@
+package io.quarkus.hibernate.reactive.config;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import io.quarkus.arc.Arc;
+import io.quarkus.arc.InjectableInstance;
+import jakarta.inject.Inject;
+import org.hibernate.reactive.mutiny.Mutiny;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.quarkus.test.QuarkusUnitTest;
+
+public class NoDatasourceTest {
+
+    @RegisterExtension
+    static QuarkusUnitTest runner = new QuarkusUnitTest()
+            .withApplicationRoot((jar) -> jar
+                    .addClass(MyEntity.class))
+            // Ideally we would not add quarkus-reactive-pg-client to the classpath and there _really_ wouldn't be a datasource,
+            // but that's inconvenient given our testing setup,
+            // so we'll just disable the implicit datasource.
+            .overrideConfigKey("quarkus.datasource.reactive", "false");
+
+    @Inject
+    InjectableInstance<Mutiny.SessionFactory> sessionFactory;
+
+    @Test
+    public void test() {
+        // Unlike Hibernate ORM, Hibernate Reactive will silently disable itself if the default datasource is missing, even if there are entities.
+        // We may want to revisit that someday, but it's not easy to do without deeper interaction between the Hibernate ORM and Reactive extensions.
+        assertThat(sessionFactory.isUnsatisfied()).isTrue();
+    }
+
+}

extensions/hibernate-reactive/deployment/src/test/java/io/quarkus/hibernate/reactive/NoConfigNoEntitiesTest.java

@@ -0,0 +1,38 @@
+package io.quarkus.hibernate.reactive.config;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import jakarta.enterprise.context.control.ActivateRequestContext;
+import jakarta.inject.Inject;
+
+import org.hibernate.reactive.mutiny.Mutiny;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.RegisterExtension;
+
+import io.quarkus.arc.InjectableInstance;
+import io.quarkus.test.QuarkusUnitTest;
+
+public class NoEntitiesNoDatasourceTest {
+
+    @RegisterExtension
+    static QuarkusUnitTest runner = new QuarkusUnitTest()
+            .withEmptyApplication()
+            // Ideally we would not add quarkus-reactive-pg-client to the classpath and there _really_ wouldn't be a datasource,
+            // but that's inconvenient given our testing setup,
+            // so we'll just disable the implicit datasource.
+            .overrideConfigKey("quarkus.datasource.reactive", "false");
+
+    @Inject
+    InjectableInstance<Mutiny.SessionFactory> sessionFactory;
+
+    // When having no entities, no configuration, and no datasource,
+    // as long as the Hibernate Reactive beans are not injected anywhere,
+    // we should still be able to start the application.
+    @Test
+    @ActivateRequestContext
+    public void test() {
+        // But Hibernate Reactive should be disabled, so its beans should not be there.
+        assertThat(sessionFactory.isUnsatisfied()).isTrue();
+    }
+
+}

extensions/hibernate-reactive/deployment/src/test/java/io/quarkus/hibernate/reactive/config/NoConfigNoEntitiesTest.java

@@ -1,4 +1,4 @@
-package io.quarkus.hibernate.reactive;
+package io.quarkus.hibernate.reactive.config;
 
 import static org.assertj.core.api.Assertions.assertThat;
 
@@ -14,7 +14,8 @@
 
 /**
  * Test that a persistence unit without any entities does get started,
- * and can be used, be it only for native queries.
+ * and can be used, be it only for native queries,
+ * as long as a datasource is present.
  */
 public class NoEntitiesTest {