Add default values for NLB target group attributes

- Add DefaultNLBProxyProtocolV2Enabled constant (false)
- Add DefaultNLBPreserveClientIPEnabled constant (true, since preserve_client_ip is enabled by default)
- Initialize test adapter with these default values
- Update test data files to include proxy_protocol_v2 and preserve_client_ip attributes

This ensures NLB target groups always have these attributes explicitly set in CloudFormation
with their default values, matching the actual behavior.

Signed-off-by: speruri <surya.srikar.peruri@zalando.de>

Author: speruri

aws/adapter.go

@@ -137,9 +137,11 @@ const (
 	// DefaultNLBCrossZone specifies the default configuration for cross
 	// zone load balancing: https://docs.aws.amazon.com/elasticloadbalancing/latest/network/network-load-balancers.html#load-balancer-attributes
 	// It it is safe to change as per https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticloadbalancingv2-loadbalancer-loadbalancerattribute.html#aws-properties-elasticloadbalancingv2-loadbalancer-loadbalancerattribute-properties
-	DefaultNLBCrossZone   = false
-	DefaultNLBHTTPEnabled = false
-	DefaultTargetGroupProtocolVersion = "HTTP1"
+	DefaultNLBCrossZone                = false
+	DefaultNLBHTTPEnabled              = false
+	DefaultTargetGroupProtocolVersion  = "HTTP1"
+	DefaultNLBProxyProtocolV2Enabled   = false
+	DefaultNLBPreserveClientIPEnabled  = true
 
 	nameTag                     = "Name"
 	LoadBalancerTypeApplication = "application"

testdata/ingress_nlb/output/templates/ing.cf

@@ -174,6 +174,14 @@
                     {
                         "Key": "deregistration_delay.timeout_seconds",
                         "Value": "0"
+                    },
+                    {
+                        "Key": "proxy_protocol_v2.enabled",
+                        "Value": "false"
+                    },
+                    {
+                        "Key": "preserve_client_ip.enabled",
+                        "Value": "true"
                     }
                 ],
                 "UnhealthyThresholdCount": 0,

testdata/ingress_nlb_dualstack/output/templates/ing.cf

@@ -174,6 +174,14 @@
                     {
                         "Key": "deregistration_delay.timeout_seconds",
                         "Value": "0"
+                    },
+                    {
+                        "Key": "proxy_protocol_v2.enabled",
+                        "Value": "false"
+                    },
+                    {
+                        "Key": "preserve_client_ip.enabled",
+                        "Value": "true"
                     }
                 ],
                 "UnhealthyThresholdCount": 0,

testdata/ingress_nlb_dualstack_annotation/output/templates/ing.cf

@@ -174,6 +174,14 @@
                     {
                         "Key": "deregistration_delay.timeout_seconds",
                         "Value": "0"
+                    },
+                    {
+                        "Key": "proxy_protocol_v2.enabled",
+                        "Value": "false"
+                    },
+                    {
+                        "Key": "preserve_client_ip.enabled",
+                        "Value": "true"
                     }
                 ],
                 "UnhealthyThresholdCount": 0,

testdata/ingress_nlb_dualstack_annotation_ipv6_tg/output/templates/ing.cf

@@ -174,6 +174,14 @@
                     {
                         "Key": "deregistration_delay.timeout_seconds",
                         "Value": "0"
+                    },
+                    {
+                        "Key": "proxy_protocol_v2.enabled",
+                        "Value": "false"
+                    },
+                    {
+                        "Key": "preserve_client_ip.enabled",
+                        "Value": "true"
                     }
                 ],
                 "UnhealthyThresholdCount": 0,

testdata/ingress_nlb_dualstack_ipv6_tg/output/templates/ing.cf

@@ -174,6 +174,14 @@
                     {
                         "Key": "deregistration_delay.timeout_seconds",
                         "Value": "0"
+                    },
+                    {
+                        "Key": "proxy_protocol_v2.enabled",
+                        "Value": "false"
+                    },
+                    {
+                        "Key": "preserve_client_ip.enabled",
+                        "Value": "true"
                     }
                 ],
                 "UnhealthyThresholdCount": 0,

testdata/ingress_nlb_ipv6_tg/output/templates/ing.cf

@@ -174,6 +174,14 @@
                     {
                         "Key": "deregistration_delay.timeout_seconds",
                         "Value": "0"
+                    },
+                    {
+                        "Key": "proxy_protocol_v2.enabled",
+                        "Value": "false"
+                    },
+                    {
+                        "Key": "preserve_client_ip.enabled",
+                        "Value": "true"
                     }
                 ],
                 "UnhealthyThresholdCount": 0,

testdata/rg_nlb/output/templates/rg.cf

@@ -174,6 +174,14 @@
                     {
                         "Key": "deregistration_delay.timeout_seconds",
                         "Value": "0"
+                    },
+                    {
+                        "Key": "proxy_protocol_v2.enabled",
+                        "Value": "false"
+                    },
+                    {
+                        "Key": "preserve_client_ip.enabled",
+                        "Value": "true"
                     }
                 ],
                 "UnhealthyThresholdCount": 0,

worker_test.go

@@ -882,7 +882,9 @@ func TestResourceConversionOneToOne(tt *testing.T) {
 				WithCustomCloudFormationClient(clientCF).
 				WithIpAddressType(scenario.ipAddressType).
 				WithTargetGroupIPAddressType(scenario.targetGroupIPAddressType).
-				WithNLBZoneAffinity(aws.DefaultZoneAffinity)
+				WithNLBZoneAffinity(aws.DefaultZoneAffinity).
+				WithNLBProxyProtocolV2(aws.DefaultNLBProxyProtocolV2Enabled).
+				WithNLBPreserveClientIP(aws.DefaultNLBPreserveClientIPEnabled)
 
 			a, err = a.UpdateManifest(ctx, clusterID, vpcID)
 			if err != nil {