make deployment-service's ML experimentation role name configurable

Author: Martin Linkhorst

cluster/cluster.yaml

@@ -1677,7 +1677,7 @@ Resources:
   DeploymentControllerMLExperimentDeploymentRole:
     Type: AWS::IAM::Role
     Properties:
-      RoleName: "{{.Cluster.LocalID}}-deployment-service-ml-experiment-deployment"
+      RoleName: "{{ .Cluster.ConfigItems.deployment_service_ml_experiments_role_name }}"
       AssumeRolePolicyDocument:
         Version: "2012-10-17"
         Statement:

cluster/config-defaults.yaml

@@ -1040,6 +1040,7 @@ deployment_service_api_role_arn: ""
 deployment_service_tokeninfo_url: ""
 deployment_service_lightstep_token: ""
 deployment_service_ml_experiments_enabled: "true"
+deployment_service_ml_experiments_role_name: "{{ .Cluster.LocalID }}-deployment-service-ml-experiment-deployment"
 deployment_service_cf_auto_expand_enabled: "false"
 deployment_service_cf_update_source_branch_changes: "true"
 deployment_service_executor_cdp_permissions: "false"

cluster/manifests/deployment-service/01-config.yaml

@@ -47,7 +47,7 @@ data:
   status-service-url-local: "http://deployment-status-service.ingress.cluster.local."
   deployment-role-arn: "arn:aws:iam::{{accountID .Cluster.InfrastructureAccount}}:role/{{.Cluster.LocalID}}-deployment-service-deployment"
 {{- if eq .Cluster.ConfigItems.deployment_service_ml_experiments_enabled "true"}}
-  ml-experiment-deployment-role-arn: "arn:aws:iam::{{accountID .Cluster.InfrastructureAccount}}:role/{{.Cluster.LocalID}}-deployment-service-ml-experiment-deployment"
+  ml-experiment-deployment-role-arn: "arn:aws:iam::{{accountID .Cluster.InfrastructureAccount}}:role/{{ .Cluster.ConfigItems.deployment_service_ml_experiments_role_name }}"
 {{- end }}
   cloudformation-enable-auto-expand: "{{.Cluster.ConfigItems.deployment_service_cf_auto_expand_enabled}}"
   cloudformation-update-source-branch-changes: "{{.Cluster.ConfigItems.deployment_service_cf_update_source_branch_changes}}"