Skip to content

Commit 2b71b45

Browse files
committed
remove write e2e tests that are to be covered by admission-controller e2e
1 parent 06b4c4f commit 2b71b45

File tree

1 file changed

+7
-15
lines changed

1 file changed

+7
-15
lines changed

test/e2e/authorization.go

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -211,16 +211,10 @@ var _ = g.Describe("Authorization [RBAC] [Zalando]", func() {
211211
}
212212
tc.data.verbs = []string{"create", "update", "delete", "patch"}
213213
})
214-
g.It("should deny write access in kube-system and visibility namespaces", func() {
215-
tc.data.namespaces = []string{"kube-system", "visibility"}
216-
tc.run(context.TODO(), cs, false)
217-
gomega.Expect(tc.output.passed).To(gomega.BeTrue(), tc.output.String())
218-
})
219-
g.It("should allow write access in namespaces other than kube-system and visibility", func() {
220-
tc.data.namespaces = []string{"", "teapot"}
221-
tc.run(context.TODO(), cs, true)
222-
gomega.Expect(tc.output.passed).To(gomega.BeTrue(), tc.output.String())
223-
})
214+
// These should be covered by the admission-controller tests.
215+
// They're written here for completeness.
216+
g.It("should deny write access in kube-system and visibility namespaces", func() {})
217+
g.It("should allow write access in namespaces other than kube-system and visibility", func() {})
224218
})
225219
g.When("the resource is a global resource", func() {
226220
g.BeforeEach(func() {
@@ -314,11 +308,9 @@ var _ = g.Describe("Authorization [RBAC] [Zalando]", func() {
314308
}
315309
tc.data.verbs = []string{"create", "update", "delete", "patch"}
316310
})
317-
g.It("should deny write access in kube-system namespace", func() {
318-
tc.data.namespaces = []string{"kube-system"}
319-
tc.run(context.TODO(), cs, false)
320-
gomega.Expect(tc.output.passed).To(gomega.BeTrue(), tc.output.String())
321-
})
311+
// This should be covered by the admission-controller tests.
312+
// It's written here for completeness.
313+
g.It("should deny write access in kube-system namespace", func() {})
322314
g.It("should allow write access in namespaces other than kube-system", func() {
323315
tc.data.namespaces = []string{"", "teapot"}
324316
tc.run(context.TODO(), cs, true)

0 commit comments

Comments
 (0)