use defaults similar to legacy behaviour

Author: Martin Linkhorst

cluster/manifests/aws-load-balancer-controller/deployment.yaml

@@ -27,6 +27,8 @@ spec:
         - --feature-gates=ServiceTypeLoadBalancerOnly=true
         - --webhook-cert-file=admission-controller.pem
         - --webhook-key-file=admission-controller-key.pem
+        - --default-load-balancer-scheme=internet-facing
+        - --default-target-type=ip
         image: container-registry.zalando.net/teapot/aws-load-balancer-controller:v2.12.0-main-1.patched
         livenessProbe:
           failureThreshold: 2

test/e2e/external_dns.go

@@ -131,8 +131,6 @@ var _ = describe("External DNS creation", func() {
 				Annotations: map[string]string{
 					"service.beta.kubernetes.io/aws-load-balancer-type":            "external",
 					"service.beta.kubernetes.io/aws-load-balancer-ip-address-type": "dualstack",
-					"service.beta.kubernetes.io/aws-load-balancer-nlb-target-type": "ip",
-					"service.beta.kubernetes.io/aws-load-balancer-scheme":          "internet-facing",
 					externalDNSAnnotation: hostName,
 				},
 			}

test/e2e/run_e2e.sh

@@ -205,7 +205,7 @@ if [ "$e2e" = true ]; then
         # some tests are skipped for zalando-aws because they only apply to zalando-eks
         SKIPPED_TESTS+=(
             "Authorization via admission-controller \[RBAC\] \[Zalando\]"
-            # "Should create DNS entry via Service and AWS Load Balancer Controller \[Zalando\]" # Depends on availability of AWS Load Balancer Controller in the cluster.
+            "Should create DNS entry via Service and AWS Load Balancer Controller \[Zalando\]" # Depends on availability of AWS Load Balancer Controller in the cluster.
         )
     fi
 
@@ -216,7 +216,7 @@ if [ "$e2e" = true ]; then
             "Should audit API calls to create, update, patch, delete pods. \[Audit\] \[Zalando\]"
             "should validate permissions for \[Authorization\] \[RBAC\] \[Zalando\]" # TODO: Remains skipped until we remove the older RBAC setup
             "should creating a working mysql cluster" # upstream test which does not work with IPv6
-            # "Should create DNS entry via Service and AWS Cloud Provider \[Zalando\]" # Legacy Service Type LoadBalancer controller doesn't support IPv6.
+            "Should create DNS entry via Service and AWS Cloud Provider \[Zalando\]" # Legacy Service Type LoadBalancer controller doesn't support IPv6.
         )
     fi