Skip to content

Commit a949907

Browse files
authored
Merge pull request #7114 from zalando-incubator/ingress/cert-enable-tag-filter
feature: ingress enable cert tag filter [1/2]
2 parents 744d80f + 9f6dd25 commit a949907

File tree

3 files changed

+13
-1
lines changed

3 files changed

+13
-1
lines changed

cluster/cluster.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1141,6 +1141,9 @@ Resources:
11411141
- Action: 'acm:DescribeCertificate'
11421142
Effect: Allow
11431143
Resource: '*'
1144+
- Action: 'acm:ListTagsForCertificate'
1145+
Effect: Allow
1146+
Resource: '*'
11441147
- Action: 'autoscaling:DescribeAutoScalingGroups'
11451148
Effect: Allow
11461149
Resource: '*'
@@ -1224,7 +1227,7 @@ Resources:
12241227
RoleName: "{{.Cluster.LocalID}}-app-ingr-ctrl"
12251228
Type: 'AWS::IAM::Role'
12261229
{{ if eq .Cluster.ConfigItems.skipper_open_policy_agent_enabled "true" }}
1227-
# Note: this is not strictly specific to Open Policy Agent and can be extend
1230+
# Note: this is not strictly specific to Open Policy Agent and can be extend
12281231
# if Skipper Ingress needs to access other AWS resources
12291232
SkipperIngressIAMRole:
12301233
Properties:

cluster/config-defaults.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,12 @@ kube_aws_ingress_controller_nlb_cross_zone: "true"
4646
kube_aws_ingress_controller_cert_polling_interval: "2m"
4747
# sets the default LB type: "network" or "application" are valid choices (overwritten by nlb_switch)
4848
kube_aws_ingress_default_lb_type: "application"
49+
# cert filter
50+
{{if eq .Cluster.Environment "production"}}
51+
kube_aws_ingress_controller_cert_filter_tag: ""
52+
{{else}}
53+
kube_aws_ingress_controller_cert_filter_tag: "kubernetes=enabled"
54+
{{end}}
4955

5056
# ALB to NLB switch
5157
# "pre":

cluster/manifests/ingress-controller/deployment.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,9 @@ spec:
5656
- --load-balancer-type={{ .Cluster.ConfigItems.kube_aws_ingress_default_lb_type }}
5757
# {{ end }}
5858
- --cert-polling-interval={{ .Cluster.ConfigItems.kube_aws_ingress_controller_cert_polling_interval }}
59+
# {{ if .Cluster.ConfigItems.kube_aws_ingress_controller_cert_filter_tag }}
60+
- --cert-filter-tag={{ .Cluster.ConfigItems.kube_aws_ingress_controller_cert_filter_tag }}
61+
# {{ end }}
5962
env:
6063
- name: CUSTOM_FILTERS
6164
value: "tag:kubernetes.io/cluster/{{ .Cluster.ID }}=owned tag:node.kubernetes.io/role=worker tag:zalando.org/ingress-enabled=true"

0 commit comments

Comments
 (0)