Skip to content

Commit b4734e7

Browse files
committed
Fix merge conflict.
Signed-off-by: Rodrigo Reis <[email protected]>
2 parents 82c7ca7 + 6d1035a commit b4734e7

File tree

5 files changed

+46
-4
lines changed

5 files changed

+46
-4
lines changed

cluster/config-defaults.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -903,6 +903,9 @@ stackset_configmap_support_enabled: "true"
903903
stackset_configmap_support_enabled: "false"
904904
{{end}}
905905

906+
# enable/disable secret support for stackset
907+
stackset_secret_support_enabled: "false"
908+
906909
# enable/disable traffic segment support for stackset
907910
stackset_enable_traffic_segments: "false"
908911
{{if eq .Cluster.Environment "e2e"}}

cluster/manifests/stackset-controller/01-stack-crd.yaml

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ spec:
349349
- maxReplicas
350350
- metrics
351351
type: object
352-
{{- if eq .Cluster.ConfigItems.stackset_configmap_support_enabled "true" }}
352+
{{- if or (eq .Cluster.ConfigItems.stackset_configmap_support_enabled "true") (eq .Cluster.ConfigItems.stackset_secret_support_enabled "true") }}
353353
configurationResources:
354354
description: ConfigurationResources describes the ConfigMaps that
355355
will be created. Later Secrets and PlatformCredentialSets will also
@@ -358,14 +358,26 @@ spec:
358358
description: ConfigurationResourcesSpec makes it possible to defined
359359
the config resources to be created
360360
properties:
361+
{{- if eq .Cluster.ConfigItems.stackset_configmap_support_enabled "true" }}
361362
configMapRef:
362-
description: ConfigMap to be versioned for Stack
363+
description: ConfigMap to be owned by Stack
364+
properties:
365+
name:
366+
description: 'Name of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
367+
TODO: Add other useful fields. apiVersion, kind, uid?'
368+
type: string
369+
type: object
370+
{{ end }}
371+
{{- if eq .Cluster.ConfigItems.stackset_secret_support_enabled "true" }}
372+
secretRef:
373+
description: Secret to be owned by Stack
363374
properties:
364375
name:
365376
description: 'Name of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
366377
TODO: Add other useful fields. apiVersion, kind, uid?'
367378
type: string
368379
type: object
380+
{{ end }}
369381
type: object
370382
type: array
371383
{{ end }}

cluster/manifests/stackset-controller/01-stackset-crd.yaml

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -596,7 +596,7 @@ spec:
596596
- maxReplicas
597597
- metrics
598598
type: object
599-
{{- if eq .Cluster.ConfigItems.stackset_configmap_support_enabled "true" }}
599+
{{- if or (eq .Cluster.ConfigItems.stackset_configmap_support_enabled "true") (eq .Cluster.ConfigItems.stackset_secret_support_enabled "true") }}
600600
configurationResources:
601601
description: ConfigurationResources describes the ConfigMaps
602602
that will be created. Later Secrets and PlatformCredentialSets
@@ -605,15 +605,28 @@ spec:
605605
description: ConfigurationResourcesSpec makes it possible
606606
to defined the config resources to be created
607607
properties:
608+
{{- if eq .Cluster.ConfigItems.stackset_configmap_support_enabled "true" }}
608609
configMapRef:
609-
description: ConfigMap to be versioned for Stack
610+
description: ConfigMap to be owned by Stack
610611
properties:
611612
name:
612613
description: 'Name of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
613614
TODO: Add other useful fields. apiVersion, kind,
614615
uid?'
615616
type: string
616617
type: object
618+
{{ end }}
619+
{{- if eq .Cluster.ConfigItems.stackset_secret_support_enabled "true" }}
620+
secretRef:
621+
description: Secret to be owned by Stack
622+
properties:
623+
name:
624+
description: 'Name of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
625+
TODO: Add other useful fields. apiVersion, kind,
626+
uid?'
627+
type: string
628+
type: object
629+
{{ end }}
617630
type: object
618631
type: array
619632
{{ end }}

cluster/manifests/stackset-controller/deployment.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@ spec:
4040
{{- if eq .Cluster.ConfigItems.stackset_configmap_support_enabled "true" }}
4141
- "--enable-configmap-support"
4242
{{- end }}
43+
{{- if eq .Cluster.ConfigItems.stackset_secret_support_enabled "true" }}
44+
- "--enable-secret-support"
45+
{{- end }}
4346
{{- if eq .Cluster.ConfigItems.stackset_enable_traffic_segments "true" }}
4447
- "--enable-traffic-segments"
4548
{{- end }}

cluster/manifests/stackset-controller/rbac.yaml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,17 @@ rules:
110110
- create
111111
- update
112112
{{- end }}
113+
{{- if eq .Cluster.ConfigItems.stackset_secret_support_enabled "true" }}
114+
- apiGroups:
115+
- ""
116+
resources:
117+
- secrets
118+
verbs:
119+
- get
120+
- list
121+
- create
122+
- update
123+
{{- end }}
113124
---
114125
apiVersion: rbac.authorization.k8s.io/v1
115126
kind: ClusterRoleBinding

0 commit comments

Comments
 (0)