Skip to content

Commit 24a202c

Browse files
committed
Remove unused constructor parameters and narrow down the @SuppressWarnings to the method where it's actually needed
1 parent c473ac9 commit 24a202c

File tree

2 files changed

+11
-13
lines changed

2 files changed

+11
-13
lines changed

src/main/java/de/zalando/sprocwrapper/proxy/GlobalValueTransformedParameter.java

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package de.zalando.sprocwrapper.proxy;
22

33
import java.lang.reflect.Method;
4-
import java.lang.reflect.Type;
54

65
import java.sql.Connection;
76

@@ -18,17 +17,15 @@
1817

1918
public class GlobalValueTransformedParameter extends StoredProcedureParameter {
2019

21-
private StoredProcedureParameter forwardingStoredProcedureParameter;
22-
@SuppressWarnings("rawtypes")
23-
private ValueTransformer valueTransformerForClass;
20+
private final StoredProcedureParameter forwardingStoredProcedureParameter;
2421

25-
@SuppressWarnings("rawtypes")
26-
private ObjectMapper globalObjectMapper;
22+
private final ValueTransformer<?, ?> valueTransformerForClass;
23+
24+
private final ObjectMapper<?> globalObjectMapper;
2725

2826
public GlobalValueTransformedParameter(final ValueTransformer<?, ?> valueTransformerForClass, final Class<?> clazz,
29-
final Type genericType, final Method m, final String typeName, final int sqlType, final int javaPosition,
30-
final boolean sensitive, final ObjectMapper<?> globalObjectMapper) throws InstantiationException,
31-
IllegalAccessException {
27+
final Method m, final String typeName, final int javaPosition, final boolean sensitive,
28+
final ObjectMapper<?> globalObjectMapper) throws InstantiationException, IllegalAccessException {
3229
super(getValueTransformedClazz(clazz, valueTransformerForClass), m, typeName, getValueTransformedTypeId(clazz),
3330
javaPosition, sensitive);
3431

@@ -64,11 +61,12 @@ public Object mapParam(final Object value, final Connection connection) {
6461
}
6562
}
6663

64+
@SuppressWarnings("unchecked")
6765
private Object getMarshaledObject(final Object o) {
6866
if (globalObjectMapper != null) {
69-
return globalObjectMapper.marshalToDb(o);
67+
return ((ObjectMapper<Object>) globalObjectMapper).marshalToDb(o);
7068
} else {
71-
return valueTransformerForClass.marshalToDb(o);
69+
return ((ValueTransformer<?, Object>) valueTransformerForClass).marshalToDb(o);
7270
}
7371
}
7472

src/main/java/de/zalando/sprocwrapper/proxy/StoredProcedureParameter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ public static StoredProcedureParameter createParameter(final Class<?> clazz, fin
6767
if (valueTransformerForClass != null) {
6868

6969
// inject the additional logic to transform types and values
70-
return new GlobalValueTransformedParameter(valueTransformerForClass, clazz, genericType, m, typeName,
71-
sqlType, javaPosition, sensitive, globalObjectMapper);
70+
return new GlobalValueTransformedParameter(valueTransformerForClass, clazz, m, typeName, javaPosition,
71+
sensitive, globalObjectMapper);
7272
} else {
7373
Integer typeId = sqlType;
7474
if (typeId == null || typeId == -1) {

0 commit comments

Comments
 (0)