Skip to content

Commit 39f426d

Browse files
authored
hugepages empty on default and updated date in codegen files (#2512)
* hugepages empty on default using string pointer and updated date of codegen files
1 parent 30ff382 commit 39f426d

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

44 files changed

+85
-70
lines changed

pkg/apis/acid.zalan.do/v1/postgresql_type.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,10 @@ type PostgresqlParam struct {
153153

154154
// ResourceDescription describes CPU and memory resources defined for a cluster.
155155
type ResourceDescription struct {
156-
CPU string `json:"cpu"`
157-
Memory string `json:"memory"`
158-
HugePages2Mi string `json:"hugepages-2Mi"`
159-
HugePages1Gi string `json:"hugepages-1Gi"`
156+
CPU string `json:"cpu"`
157+
Memory string `json:"memory"`
158+
HugePages2Mi *string `json:"hugepages-2Mi"`
159+
HugePages1Gi *string `json:"hugepages-1Gi"`
160160
}
161161

162162
// Resources describes requests and limits for the cluster resouces.

pkg/apis/acid.zalan.do/v1/zz_generated.deepcopy.go

Lines changed: 21 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/cluster/k8sres.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -267,14 +267,14 @@ func fillResourceList(spec acidv1.ResourceDescription, defaults acidv1.ResourceD
267267
}
268268
}
269269

270-
if spec.HugePages2Mi != "" {
271-
requests[v1.ResourceHugePagesPrefix+"2Mi"], err = resource.ParseQuantity(spec.HugePages2Mi)
270+
if spec.HugePages2Mi != nil {
271+
requests[v1.ResourceHugePagesPrefix+"2Mi"], err = resource.ParseQuantity(*spec.HugePages2Mi)
272272
if err != nil {
273273
return nil, fmt.Errorf("could not parse hugepages-2Mi quantity: %v", err)
274274
}
275275
}
276-
if spec.HugePages1Gi != "" {
277-
requests[v1.ResourceHugePagesPrefix+"1Gi"], err = resource.ParseQuantity(spec.HugePages1Gi)
276+
if spec.HugePages1Gi != nil {
277+
requests[v1.ResourceHugePagesPrefix+"1Gi"], err = resource.ParseQuantity(*spec.HugePages1Gi)
278278
if err != nil {
279279
return nil, fmt.Errorf("could not parse hugepages-1Gi quantity: %v", err)
280280
}

pkg/cluster/k8sres_test.go

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3127,12 +3127,12 @@ func TestGenerateResourceRequirements(t *testing.T) {
31273127
Spec: acidv1.PostgresSpec{
31283128
Resources: &acidv1.Resources{
31293129
ResourceRequests: acidv1.ResourceDescription{
3130-
HugePages2Mi: "128Mi",
3131-
HugePages1Gi: "1Gi",
3130+
HugePages2Mi: k8sutil.StringToPointer("128Mi"),
3131+
HugePages1Gi: k8sutil.StringToPointer("1Gi"),
31323132
},
31333133
ResourceLimits: acidv1.ResourceDescription{
3134-
HugePages2Mi: "256Mi",
3135-
HugePages1Gi: "2Gi",
3134+
HugePages2Mi: k8sutil.StringToPointer("256Mi"),
3135+
HugePages1Gi: k8sutil.StringToPointer("2Gi"),
31363136
},
31373137
},
31383138
TeamID: "acid",
@@ -3145,14 +3145,14 @@ func TestGenerateResourceRequirements(t *testing.T) {
31453145
ResourceRequests: acidv1.ResourceDescription{
31463146
CPU: "100m",
31473147
Memory: "100Mi",
3148-
HugePages2Mi: "128Mi",
3149-
HugePages1Gi: "1Gi",
3148+
HugePages2Mi: k8sutil.StringToPointer("128Mi"),
3149+
HugePages1Gi: k8sutil.StringToPointer("1Gi"),
31503150
},
31513151
ResourceLimits: acidv1.ResourceDescription{
31523152
CPU: "1",
31533153
Memory: "500Mi",
3154-
HugePages2Mi: "256Mi",
3155-
HugePages1Gi: "2Gi",
3154+
HugePages2Mi: k8sutil.StringToPointer("256Mi"),
3155+
HugePages1Gi: k8sutil.StringToPointer("2Gi"),
31563156
},
31573157
},
31583158
},
@@ -3174,12 +3174,12 @@ func TestGenerateResourceRequirements(t *testing.T) {
31743174
DockerImage: "test-image",
31753175
Resources: &acidv1.Resources{
31763176
ResourceRequests: acidv1.ResourceDescription{
3177-
HugePages2Mi: "128Mi",
3178-
HugePages1Gi: "1Gi",
3177+
HugePages2Mi: k8sutil.StringToPointer("128Mi"),
3178+
HugePages1Gi: k8sutil.StringToPointer("1Gi"),
31793179
},
31803180
ResourceLimits: acidv1.ResourceDescription{
3181-
HugePages2Mi: "256Mi",
3182-
HugePages1Gi: "2Gi",
3181+
HugePages2Mi: k8sutil.StringToPointer("256Mi"),
3182+
HugePages1Gi: k8sutil.StringToPointer("2Gi"),
31833183
},
31843184
},
31853185
},
@@ -3194,14 +3194,14 @@ func TestGenerateResourceRequirements(t *testing.T) {
31943194
ResourceRequests: acidv1.ResourceDescription{
31953195
CPU: "100m",
31963196
Memory: "100Mi",
3197-
HugePages2Mi: "128Mi",
3198-
HugePages1Gi: "1Gi",
3197+
HugePages2Mi: k8sutil.StringToPointer("128Mi"),
3198+
HugePages1Gi: k8sutil.StringToPointer("1Gi"),
31993199
},
32003200
ResourceLimits: acidv1.ResourceDescription{
32013201
CPU: "1",
32023202
Memory: "500Mi",
3203-
HugePages2Mi: "256Mi",
3204-
HugePages1Gi: "2Gi",
3203+
HugePages2Mi: k8sutil.StringToPointer("256Mi"),
3204+
HugePages1Gi: k8sutil.StringToPointer("2Gi"),
32053205
},
32063206
},
32073207
},

pkg/generated/clientset/versioned/clientset.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/generated/clientset/versioned/doc.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/generated/clientset/versioned/fake/clientset_generated.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/generated/clientset/versioned/fake/doc.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/generated/clientset/versioned/fake/register.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/generated/clientset/versioned/scheme/doc.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)