Fix updating SynchronousNodeCount (#2552) (#2558)

cstohr1 · web-flow · commit 9bb5d8add7d9 · 2024-03-05T09:37:06.000+01:00
CRD support for synchronous_node_count was previously added in #1484, however the desired SynchronousNodeCount was not compared to the actual patroni configuration, which meant it was never updated.
diff --git a/pkg/cluster/sync.go b/pkg/cluster/sync.go
@@ -643,6 +643,9 @@ func (c *Cluster) checkAndSetGlobalPostgreSQLConfiguration(pod *v1.Pod, effectiv
 	if desiredPatroniConfig.SynchronousModeStrict != effectivePatroniConfig.SynchronousModeStrict {
 		configToSet["synchronous_mode_strict"] = desiredPatroniConfig.SynchronousModeStrict
 	}
+	if desiredPatroniConfig.SynchronousNodeCount != effectivePatroniConfig.SynchronousNodeCount {
+		configToSet["synchronous_node_count"] = desiredPatroniConfig.SynchronousNodeCount
+	}
 	if desiredPatroniConfig.TTL > 0 && desiredPatroniConfig.TTL != effectivePatroniConfig.TTL {
 		configToSet["ttl"] = desiredPatroniConfig.TTL
 	}

Original file line number	Diff line number	Diff line change
`@@ -643,6 +643,9 @@ func (c Cluster) checkAndSetGlobalPostgreSQLConfiguration(pod v1.Pod, effectiv`
`643`	`643`	`if desiredPatroniConfig.SynchronousModeStrict != effectivePatroniConfig.SynchronousModeStrict {`
`644`	`644`	`configToSet["synchronous_mode_strict"] = desiredPatroniConfig.SynchronousModeStrict`
`645`	`645`	`}`
	`646`	`+ if desiredPatroniConfig.SynchronousNodeCount != effectivePatroniConfig.SynchronousNodeCount {`
	`647`	`+ configToSet["synchronous_node_count"] = desiredPatroniConfig.SynchronousNodeCount`
	`648`	`+ }`
`646`	`649`	`if desiredPatroniConfig.TTL > 0 && desiredPatroniConfig.TTL != effectivePatroniConfig.TTL {`
`647`	`650`	`configToSet["ttl"] = desiredPatroniConfig.TTL`
`648`	`651`	`}`