Skip to content

Commit 511a664

Browse files
committed
refator/fix: backoff v5 usage
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
1 parent b6c9ce0 commit 511a664

2 files changed

Lines changed: 9 additions & 8 deletions

File tree

net/redisclient.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -352,13 +352,14 @@ func (r *RedisRingClient) startUpdater(ctx context.Context) {
352352

353353
func (r *RedisRingClient) RingAvailable() bool {
354354
var err error
355-
err = backoff.Retry(func() error {
355+
356+
_, err = backoff.Retry(context.TODO(), func() (string, error) {
356357
_, err = r.ring.Ping(context.Background()).Result()
357358
if err != nil {
358359
r.log.Infof("Failed to ping redis, retry with backoff: %v", err)
359360
}
360-
return err
361-
}, backoff.WithMaxRetries(backoff.NewExponentialBackOff(), 7))
361+
return "", err
362+
}, backoff.WithBackOff(backoff.NewExponentialBackOff()), backoff.WithMaxTries(7))
362363

363364
return err == nil
364365
}

swarm/kubernetes.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package swarm
22

33
import (
4+
"context"
45
"crypto/tls"
56
"crypto/x509"
67
"errors"
@@ -52,7 +53,6 @@ type ClientKubernetes struct {
5253
httpClient *http.Client
5354
apiURL string
5455
token string
55-
retry backoff.BackOff
5656
quit chan struct{}
5757
}
5858

@@ -69,13 +69,14 @@ func (c *ClientKubernetes) Get(s string) (*http.Response, error) {
6969
return nil, err
7070
}
7171

72-
err = backoff.Retry(func() error {
72+
// backoff.WithMaxRetries(backoff.NewConstantBackOff(5*time.Second), maxRetries),
73+
_, err = backoff.Retry(context.TODO(), func() (string, error) {
7374
rsp, err = c.httpClient.Do(req)
7475
if err != nil {
7576
log.Infof("SWARM: request to %s failed: %v, retrying..", s, err)
7677
}
77-
return err
78-
}, c.retry)
78+
return "", err
79+
}, backoff.WithBackOff(backoff.NewConstantBackOff(5*time.Second)), backoff.WithMaxTries(maxRetries))
7980

8081
if err != nil {
8182
log.Errorf("SWARM: Give up now, request to %s failed: %v", s, err)
@@ -113,7 +114,6 @@ func NewClientKubernetes(kubernetesInCluster bool, kubernetesURL string) (*Clien
113114
httpClient: httpClient,
114115
apiURL: apiURL,
115116
token: token,
116-
retry: backoff.WithMaxRetries(backoff.NewConstantBackOff(5*time.Second), maxRetries),
117117
quit: quit,
118118
}, nil
119119
}

0 commit comments

Comments
 (0)