Optimization: don't send committedState, but extract from computedStates

zalmoxisus · zalmoxisus · commit 5d82a7ba4069 · 2016-11-01T11:46:39.000+02:00
diff --git a/package.json b/package.json
@@ -78,8 +78,8 @@
     "react-redux": "^4.4.5",
     "redux": "^3.5.2",
     "redux-devtools": "^3.3.1",
-    "redux-devtools-instrument": "^1.3.2",
-    "remotedev-app": "^0.8.2",
+    "redux-devtools-instrument": "^1.3.3",
+    "remotedev-app": "^0.9.0-beta",
     "remotedev-slider": "^1.1.1",
     "remotedev-utils": "0.0.1"
   }
diff --git a/src/app/api/index.js b/src/app/api/index.js
@@ -37,7 +37,7 @@ export function toContentScript(message, serializeState, serializeAction, should
       message.payload = rest;
       message.actionsById = stringify(actionsById, serializeAction);
       message.computedStates = stringify(computedStates, serializeState);
-      message.committedState = stringify(committedState, serializeState);
+      message.committedState = typeof committedState !== 'undefined';
     }
   }
   message.serialize = shouldSerialize;
diff --git a/test/app/inject/api.spec.js b/test/app/inject/api.spec.js
@@ -73,7 +73,7 @@ describe('API', () => {
       serialize: undefined,
       actionsById: undefined,
       computedStates: undefined,
-      committedState: undefined,
+      committedState: false,
       instanceId: undefined,
       name: '',
       source: '@devtools-page'

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ export function toContentScript(message, serializeState, serializeAction, should`
`37`	`37`	`message.payload = rest;`
`38`	`38`	`message.actionsById = stringify(actionsById, serializeAction);`
`39`	`39`	`message.computedStates = stringify(computedStates, serializeState);`
`40`		`- message.committedState = stringify(committedState, serializeState);`
	`40`	`+ message.committedState = typeof committedState !== 'undefined';`
`41`	`41`	`}`
`42`	`42`	`}`
`43`	`43`	`message.serialize = shouldSerialize;`