Skip to content

Commit 66e13a2

Browse files
committed
Bring back ability to open a chrome panel
Related to #52.
1 parent d3de54f commit 66e13a2

File tree

6 files changed

+13
-7
lines changed

6 files changed

+13
-7
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,8 @@ To include it in a chrome extension's content script follow [the example](https:
115115
```js
116116
window.devToolsExtension.open();
117117
```
118+
#### How to keep DevTools window focused all the time in a chrome panel
119+
To enable chrome panels feature in Chrome, type in `chrome://flags/#enable-panels` in the url bar and click on "enable" under "enable panels". Make sure to click on "relaunch now " at the bottom of the page, to take effect.
118120
#### How to include DevTools in the page
119121
You may open DevTools in a new window (by opening context menu with right mouse click), from popup (clicking on the browser action button) or from Chrome dev panel. If you still, for some reason, want to include it directly in your page, load the following url in iframe: `chrome-extension://lmhkpmbekcpmknklioeibfkpmmfibljd/window.html`. You'd probably include it in a docker or in a resizeable component.
120122
#### How to enable/disable errors notifying

src/app/containers/App.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ export default class App extends Component {
6161
: null }
6262
<Button
6363
Icon={RemoteIcon}
64-
onClick={() => { this.openWindow('panel'); }}
64+
onClick={() => { this.openWindow('remote'); }}
6565
>Remote</Button>
6666
<Button
6767
Icon={SettingsIcon}

src/browser/extension/background/contextMenus.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ const menus = [
44
{ id: 'devtools-left', title: 'To left' },
55
{ id: 'devtools-right', title: 'To right' },
66
{ id: 'devtools-bottom', title: 'To bottom' },
7-
{ id: 'devtools-panel', title: 'In panel' }
7+
{ id: 'devtools-panel', title: 'Open in a chrome panel (enable in Chrome settings)' },
8+
{ id: 'devtools-remote', title: 'Open Remote DevTools' }
89
];
910
let pageUrl;
1011
let pageTab;
@@ -31,7 +32,7 @@ export default function createMenu(forUrl, tabId) {
3132
menus.forEach(({ id, title }) => {
3233
chrome.contextMenus.create({
3334
id: id,
34-
title: title + ' (' + shortcuts[id] + ')',
35+
title: title + (shortcuts[id] ? ' (' + shortcuts[id] + ')' : ''),
3536
contexts: ['all'],
3637
documentUrlPatterns: [url],
3738
onclick: () => { openDevToolsWindow(id); }

src/browser/extension/background/messaging.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ function messaging(request, sender, sendResponse) {
4141
}
4242
if (request.type === 'OPEN') {
4343
let position = 'devtools-left';
44-
if (['panel', 'left', 'right', 'bottom'].indexOf(request.position) !== -1) position = 'devtools-' + request.position;
44+
if (['remote', 'panel', 'left', 'right', 'bottom'].indexOf(request.position) !== -1) position = 'devtools-' + request.position;
4545
openDevToolsWindow(position);
4646
return true;
4747
}

src/browser/extension/background/openWindow.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export default function openDevToolsWindow(position) {
2525
};
2626
if (action === 'open') {
2727
getMonitorName(position, monitorName => {
28-
options.url = chrome.extension.getURL(url + '#' + monitorName + '/' + position);
28+
options.url = chrome.extension.getURL(url + (monitorName ? '#' + monitorName + '/' + position : ''));
2929
chrome.windows.create(options, (win) => {
3030
windows[position] = win.id;
3131
});
@@ -46,6 +46,9 @@ export default function openDevToolsWindow(position) {
4646
params.width = window.screen.availWidth;
4747
break;
4848
case 'devtools-panel':
49+
params.type = 'panel';
50+
break;
51+
case 'devtools-remote':
4952
params = { width: 850, height: 600 };
5053
url = 'remote.html';
5154
break;

src/browser/extension/manifest.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@
3131
},
3232
"description": "DevTools window to bottom"
3333
},
34-
"devtools-panel": {
34+
"devtools-remote": {
3535
"suggested_key": {
3636
"default": "Alt+Shift+Up",
3737
"mac": "Command+MacCtrl+Up"
3838
},
39-
"description": "DevTools in panel"
39+
"description": "Remote DevTools"
4040
}
4141
},
4242
"icons": {

0 commit comments

Comments
 (0)