Appsets created/managed by Helm charts do not have their children apps displayed in the checks results

[ahinh43]

Kubechecks has the ability to do a diff on all of the children applications of an appset if the appset manifest is changed (i.e via helmValues or if the generator expression changes to add new apps) but that behavior does not seem to kick in if the appset being modified is managed or created by a helm chart, rather than a direct appset manifest. There doesn't seem to be any messages that easily identifies this behavior in the logs.

[Greyeye]

This has been a wild goose chase,
During the kubechecks starts up, it builds the lists of applications and applicationsets using argo-cd client (via api call)
code here

and each application/applicationsets contain the repoURL and path. Kubechecks would determine the change of the files and match to the path to call it if these are for certain apps/appset it is monitoring.

Old method app-in-app (or in this case app-in-appsets) worked because the change to the root app will trigger which appset is changing, and forced the kubechecks to generate the diffs.

When we build the applicationset manifests using a Helm chart, the path does not contain the expected applicationset resource yaml but a helm chart.

So the work we need is

1. identify if the changed file/manifest belongs to appset app
2. run helm dependancy download
3. run helm template generate with one or more values file to generate the applicationset file.
4. use the applicationset and run diffGen (api call to argo-cd to get the live applicationset)
5. generate all the impacted applications that has been generated by the applicationset
6. run diffgen for each application manifest to the live manifest.