Skip to content

Commit 0196bdf

Browse files
committed
shouldReset → resetStyles
1 parent c1aa596 commit 0196bdf

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

src/ElementPortal.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,9 @@ const noop = () => {};
1010
const ElementPortal = createReactClass({
1111
propTypes: {
1212
selector: PropTypes.string,
13+
component: PropTypes.func,
1314
mapDomNodeToProps: PropTypes.func,
14-
shouldReset: PropTypes.bool,
15-
component: PropTypes.func
15+
resetStyle: PropTypes.bool
1616
},
1717

1818
componentDidMount() {
@@ -36,8 +36,8 @@ const ElementPortal = createReactClass({
3636
renderNode(node) {
3737
const mapDomNodeToProps = this.props.mapDomNodeToProps || noop;
3838

39-
if (this.props.shouldReset) {
40-
node.className = '';
39+
if (this.props.resetStyle) {
40+
node.removeAttribute('class');
4141
node.removeAttribute('style');
4242
}
4343

src/withElementPortal.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ function getDisplayName(Component) {
66
}
77

88
const withElementPortal = (Child) => {
9-
const Portal = ({ selector, shouldReset, mapDomNodeToProps, ...childProps }) => {
9+
const Portal = ({ selector, resetStyle, mapDomNodeToProps, ...childProps }) => {
1010
const ChildWrapper = (props) => <Child {...childProps} {...props} />;
1111
return <ElementPortal
1212
selector={selector}
13-
mapDomNodeToProps={mapDomNodeToProps}
14-
shouldReset={shouldReset}
1513
component={ChildWrapper}
14+
mapDomNodeToProps={mapDomNodeToProps}
15+
resetStyle={resetStyle}
1616
/>;
1717
};
1818

test/ElementPortal.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ test('erases classes and styles', t => {
127127
const Greeting = () => (<div>Hello</div>);
128128
render(
129129
<div>
130-
<ElementPortal selector={`#${headerId}`} shouldReset>
130+
<ElementPortal selector={`#${headerId}`} resetStyle>
131131
<Greeting/>
132132
</ElementPortal>
133133
</div>,

0 commit comments

Comments
 (0)