Skip to content

Commit 1ff7343

Browse files
committed
add extra note for the new unsharedLdapConnection method
1 parent 26c756d commit 1ff7343

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ A [JUnit Rule](//github.com/junit-team/junit/wiki/Rules) for running an embedded
77
* you want to test your LDAP integration code without affecting your LDAP server
88
* you are working with LDAP schema changes that you would like to test without changing the schema at the shared LDAP server
99
* you are refactoring legacy code where LDAP calls is tightly coupled with your business logic and wants to start by testing the legacy code from the "outside" (as suggested by [Michael Feathers](http://www.informit.com/store/working-effectively-with-legacy-code-9780131177055?aid=15d186bd-1678-45e9-8ad3-fe53713e811b))
10-
* for this exact reason all instances returned from the EmbeddedLdapRule is instrumented to suppress "close" calls so that your legacy code will not destroy the current Context/DirContext or LdapInterface
10+
* for this exact reason most instances returned from the EmbeddedLdapRule is instrumented to suppress "close" calls so that your legacy code will not destroy the current Context/DirContext or LdapInterface
11+
* **note**: if you used the new unsharedLdapConnection() method, the returned instance will not have this guarantee as it returns a instance of UnboundID LDAPConnection which is declared 'final'.
1112

1213
## Status
1314
This library is distributed through the [Sonatype OSS repo](https://oss.sonatype.org/) and should thus be widely available.

0 commit comments

Comments
 (0)